From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] repair: fix messages from set_nlinks
Date: Fri, 02 Mar 2012 16:09:51 -0600 [thread overview]
Message-ID: <4F51452F.90608@sandeen.net> (raw)
In-Reply-To: <20120228174251.GB6148@infradead.org>
On 2/28/12 11:42 AM, Christoph Hellwig wrote:
> Link counts are unsigned and need to be printed as such. Also only
> print the varning about upgrading the inode version if the inode was
warning
> version 1 before.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Well you got reviews for the hard part, 1/2 :)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> Index: xfsprogs-dev/repair/phase7.c
> ===================================================================
> --- xfsprogs-dev.orig/repair/phase7.c 2012-02-28 12:45:52.627849317 +0100
> +++ xfsprogs-dev/repair/phase7.c 2012-02-28 14:03:20.475986024 +0100
> @@ -40,19 +40,20 @@ set_nlinks(
>
> if (!no_modify) {
> *dirty = 1;
> - do_warn(_("resetting inode %" PRIu64 " nlinks from %d to %d\n"),
> + do_warn(_("resetting inode %" PRIu64 " nlinks from %u to %u\n"),
> ino, dinoc->di_nlink, nrefs);
>
> - if (nrefs > XFS_MAXLINK_1) {
> + if (dinoc->di_version == 1 && nrefs > XFS_MAXLINK_1) {
> ASSERT(fs_inode_nlink);
> do_warn(
> -_("nlinks %d will overflow v1 ino, ino %" PRIu64 " will be converted to version 2\n"),
> +_("nlinks %u will overflow v1 ino, ino %" PRIu64 " will be converted to version 2\n"),
> nrefs, ino);
>
> }
> dinoc->di_nlink = nrefs;
> } else {
> - do_warn(_("would have reset inode %" PRIu64 " nlinks from %d to %d\n"),
> + do_warn(
> +_("would have reset inode %" PRIu64 " nlinks from %u to %u\n"),
> ino, dinoc->di_nlink, nrefs);
> }
> }
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-02 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 17:42 [PATCH 1/2] repair: fix the variable-width nlink array Christoph Hellwig
2012-02-28 17:42 ` [PATCH 2/2] repair: fix messages from set_nlinks Christoph Hellwig
2012-03-02 22:09 ` Eric Sandeen [this message]
2012-03-01 21:28 ` [PATCH 1/2] repair: fix the variable-width nlink array Ben Myers
2012-03-02 7:44 ` Christoph Hellwig
2012-03-26 17:49 ` Ben Myers
2012-03-27 14:59 ` Christoph Hellwig
2012-03-02 9:41 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F51452F.90608@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.