From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: [PATCH 3/3] vmevent: Should not grab mutex in the atomic context
Date: Sat, 3 Mar 2012 04:09:32 +0400 [thread overview]
Message-ID: <20120303000932.GC30207@oksana.dev.rtsoft.ru> (raw)
There is not need to grab mutex in the atomic context, moreover this is
wrong and causes the following bug:
BUG: sleeping function called from invalid context at kernel/mutex.c:271
in_atomic(): 1, irqs_disabled(): 1, pid: 1056, name: m
no locks held by m/1056.
irq event stamp: 58768
hardirqs last enabled at (58767): [<ffffffff8101ca35>] do_page_fault+0x275/0x450
hardirqs last disabled at (58768): [<ffffffff81325a2b>] apic_timer_interrupt+0x6b/0x80
softirqs last enabled at (58676): [<ffffffff81038def>] __do_softirq+0x10f/0x160
softirqs last disabled at (58671): [<ffffffff813262ac>] call_softirq+0x1c/0x26
Pid: 1056, comm: m Not tainted 3.2.0+ #3
Call Trace:
<IRQ> [<ffffffff81062530>] ? print_irqtrace_events+0xd0/0xe0
[<ffffffff8102f5da>] __might_sleep+0x12a/0x1e0
[<ffffffff81321dbc>] mutex_lock_nested+0x3c/0x340
[<ffffffff81053a8c>] ? __run_hrtimer+0x4c/0x100
[<ffffffff810bd920>] ? vmevent_read+0x100/0x100
[<ffffffff810bd79e>] vmevent_sample+0x6e/0xf0
[<ffffffff810bd946>] vmevent_timer_fn+0x26/0x60
[<ffffffff81053a92>] __run_hrtimer+0x52/0x100
[<ffffffff81054463>] hrtimer_interrupt+0xf3/0x220
[<ffffffff810166d4>] smp_apic_timer_interrupt+0x64/0xa0
[<ffffffff81325a30>] apic_timer_interrupt+0x70/0x80
<EOI> [<ffffffff8101ca3a>] ? do_page_fault+0x27a/0x450
[<ffffffff8101ca35>] ? do_page_fault+0x275/0x450
[<ffffffff810036bf>] ? do_softirq+0x6f/0xc0
[<ffffffff8132485d>] ? retint_restore_args+0xe/0xe
[<ffffffff8132484a>] ? retint_swapgs+0xe/0x13
[<ffffffff8116b31d>] ? trace_hardirqs_off_thunk+0x3a/0x3c
[<ffffffff81324a3f>] page_fault+0x1f/0x30
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
The patch is for git://github.com/penberg/linux.git vmevent/core.
mm/vmevent.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/mm/vmevent.c b/mm/vmevent.c
index 1375f9d..1dbefb5 100644
--- a/mm/vmevent.c
+++ b/mm/vmevent.c
@@ -71,8 +71,6 @@ static void vmevent_sample(struct vmevent_watch *watch)
if (!vmevent_match(watch, &event))
return;
- mutex_lock(&watch->mutex);
-
watch->pending = true;
if (watch->config.event_attrs & VMEVENT_EATTR_NR_AVAIL_PAGES)
@@ -85,8 +83,6 @@ static void vmevent_sample(struct vmevent_watch *watch)
watch->attr_values[n++] = event.nr_swap_pages;
watch->nr_attrs = n;
-
- mutex_unlock(&watch->mutex);
}
static enum hrtimer_restart vmevent_timer_fn(struct hrtimer *hrtimer)
--
1.7.7.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: [PATCH 3/3] vmevent: Should not grab mutex in the atomic context
Date: Sat, 3 Mar 2012 04:09:32 +0400 [thread overview]
Message-ID: <20120303000932.GC30207@oksana.dev.rtsoft.ru> (raw)
There is not need to grab mutex in the atomic context, moreover this is
wrong and causes the following bug:
BUG: sleeping function called from invalid context at kernel/mutex.c:271
in_atomic(): 1, irqs_disabled(): 1, pid: 1056, name: m
no locks held by m/1056.
irq event stamp: 58768
hardirqs last enabled at (58767): [<ffffffff8101ca35>] do_page_fault+0x275/0x450
hardirqs last disabled at (58768): [<ffffffff81325a2b>] apic_timer_interrupt+0x6b/0x80
softirqs last enabled at (58676): [<ffffffff81038def>] __do_softirq+0x10f/0x160
softirqs last disabled at (58671): [<ffffffff813262ac>] call_softirq+0x1c/0x26
Pid: 1056, comm: m Not tainted 3.2.0+ #3
Call Trace:
<IRQ> [<ffffffff81062530>] ? print_irqtrace_events+0xd0/0xe0
[<ffffffff8102f5da>] __might_sleep+0x12a/0x1e0
[<ffffffff81321dbc>] mutex_lock_nested+0x3c/0x340
[<ffffffff81053a8c>] ? __run_hrtimer+0x4c/0x100
[<ffffffff810bd920>] ? vmevent_read+0x100/0x100
[<ffffffff810bd79e>] vmevent_sample+0x6e/0xf0
[<ffffffff810bd946>] vmevent_timer_fn+0x26/0x60
[<ffffffff81053a92>] __run_hrtimer+0x52/0x100
[<ffffffff81054463>] hrtimer_interrupt+0xf3/0x220
[<ffffffff810166d4>] smp_apic_timer_interrupt+0x64/0xa0
[<ffffffff81325a30>] apic_timer_interrupt+0x70/0x80
<EOI> [<ffffffff8101ca3a>] ? do_page_fault+0x27a/0x450
[<ffffffff8101ca35>] ? do_page_fault+0x275/0x450
[<ffffffff810036bf>] ? do_softirq+0x6f/0xc0
[<ffffffff8132485d>] ? retint_restore_args+0xe/0xe
[<ffffffff8132484a>] ? retint_swapgs+0xe/0x13
[<ffffffff8116b31d>] ? trace_hardirqs_off_thunk+0x3a/0x3c
[<ffffffff81324a3f>] page_fault+0x1f/0x30
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
The patch is for git://github.com/penberg/linux.git vmevent/core.
mm/vmevent.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/mm/vmevent.c b/mm/vmevent.c
index 1375f9d..1dbefb5 100644
--- a/mm/vmevent.c
+++ b/mm/vmevent.c
@@ -71,8 +71,6 @@ static void vmevent_sample(struct vmevent_watch *watch)
if (!vmevent_match(watch, &event))
return;
- mutex_lock(&watch->mutex);
-
watch->pending = true;
if (watch->config.event_attrs & VMEVENT_EATTR_NR_AVAIL_PAGES)
@@ -85,8 +83,6 @@ static void vmevent_sample(struct vmevent_watch *watch)
watch->attr_values[n++] = event.nr_swap_pages;
watch->nr_attrs = n;
-
- mutex_unlock(&watch->mutex);
}
static enum hrtimer_restart vmevent_timer_fn(struct hrtimer *hrtimer)
--
1.7.7.6
next reply other threads:[~2012-03-03 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 0:09 Anton Vorontsov [this message]
2012-03-03 0:09 ` [PATCH 3/3] vmevent: Should not grab mutex in the atomic context Anton Vorontsov
2012-03-04 16:37 ` Pekka Enberg
2012-03-04 16:37 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120303000932.GC30207@oksana.dev.rtsoft.ru \
--to=anton.vorontsov@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.