From: Pablo Neira Ayuso <pablo@netfilter.org>
To: santosh prasad nayak <santoshprasadnayak@gmail.com>
Cc: bart.de.schuymer@pandora.be, kaber@trash.net,
shemminger@vyatta.com, davem@davemloft.net,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: Resend [PATCH] netfilter: Fix copy_to_user too small size parametre.
Date: Sun, 04 Mar 2012 17:03:57 +0000 [thread overview]
Message-ID: <20120304170357.GA24080@1984> (raw)
In-Reply-To: <CAOD=uF6UvL2oEmJmgak4X5L0PR+qQi2=Vr22AUsAxLLOfi44rw@mail.gmail.com>
On Sun, Mar 04, 2012 at 06:09:08PM +0530, santosh prasad nayak wrote:
> where is it broken ?
> Can you please explain ?
> >> + strncpy(name, t->u.target->name, sizeof(name));
> >> hlp = ubase + (((char *)e + e->target_offset) - base);
> >> t = (struct ebt_entry_target *)(((char *)e) + e->target_offset);
In ebt_make_names, you dereference t but it is not initialized.
Note that strncpy refers to t->u.target->name which is initialized a
couple of lines after it.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: santosh prasad nayak <santoshprasadnayak@gmail.com>
Cc: bart.de.schuymer@pandora.be, kaber@trash.net,
shemminger@vyatta.com, davem@davemloft.net,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: Resend [PATCH] netfilter: Fix copy_to_user too small size parametre.
Date: Sun, 4 Mar 2012 18:03:57 +0100 [thread overview]
Message-ID: <20120304170357.GA24080@1984> (raw)
In-Reply-To: <CAOD=uF6UvL2oEmJmgak4X5L0PR+qQi2=Vr22AUsAxLLOfi44rw@mail.gmail.com>
On Sun, Mar 04, 2012 at 06:09:08PM +0530, santosh prasad nayak wrote:
> where is it broken ?
> Can you please explain ?
> >> + strncpy(name, t->u.target->name, sizeof(name));
> >> hlp = ubase + (((char *)e + e->target_offset) - base);
> >> t = (struct ebt_entry_target *)(((char *)e) + e->target_offset);
In ebt_make_names, you dereference t but it is not initialized.
Note that strncpy refers to t->u.target->name which is initialized a
couple of lines after it.
next prev parent reply other threads:[~2012-03-04 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 17:09 Resend [PATCH] netfilter: Fix copy_to_user too small size parametre santosh nayak
2012-03-01 17:21 ` santosh nayak
2012-03-02 9:05 ` David Laight
2012-03-02 9:05 ` David Laight
2012-03-02 10:01 ` Pablo Neira Ayuso
2012-03-02 10:01 ` Pablo Neira Ayuso
2012-03-04 12:18 ` Pablo Neira Ayuso
2012-03-04 12:18 ` Pablo Neira Ayuso
2012-03-04 12:39 ` santosh prasad nayak
2012-03-04 12:51 ` santosh prasad nayak
2012-03-04 17:03 ` Pablo Neira Ayuso [this message]
2012-03-04 17:03 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120304170357.GA24080@1984 \
--to=pablo@netfilter.org \
--cc=bart.de.schuymer@pandora.be \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=santoshprasadnayak@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.