All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: kernel@pengutronix.de, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] RM: OMAP4: board-4430sdp: don't initialize value that is never used
Date: Mon, 5 Mar 2012 10:23:11 -0800	[thread overview]
Message-ID: <20120305182311.GD12083@atomide.com> (raw)
In-Reply-To: <1328823034-9668-1-git-send-email-u.kleine-koenig@pengutronix.de>

* Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [120209 13:00]:
> sdp4430_spi_board_info.irq was initialized to ETH_KS8851_IRQ and in
> omap_4430sdp_init() overwritten with gpio_to_irq(ETH_KS8851_IRQ) before
> sdp4430_spi_board_info was registered. This is a bit confusing, so
> better don't initialize .irq and document that it is set later.

Thanks applying into board branch.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] RM: OMAP4: board-4430sdp: don't initialize value that is never used
Date: Mon, 5 Mar 2012 10:23:11 -0800	[thread overview]
Message-ID: <20120305182311.GD12083@atomide.com> (raw)
In-Reply-To: <1328823034-9668-1-git-send-email-u.kleine-koenig@pengutronix.de>

* Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> [120209 13:00]:
> sdp4430_spi_board_info.irq was initialized to ETH_KS8851_IRQ and in
> omap_4430sdp_init() overwritten with gpio_to_irq(ETH_KS8851_IRQ) before
> sdp4430_spi_board_info was registered. This is a bit confusing, so
> better don't initialize .irq and document that it is set later.

Thanks applying into board branch.

Regards,

Tony

  reply	other threads:[~2012-03-05 18:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 21:30 [PATCH] RM: OMAP4: board-4430sdp: don't initialize value that is never used Uwe Kleine-König
2012-02-09 21:30 ` Uwe Kleine-König
2012-03-05 18:23 ` Tony Lindgren [this message]
2012-03-05 18:23   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120305182311.GD12083@atomide.com \
    --to=tony@atomide.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.