From: Tony Lindgren <tony@atomide.com>
To: Bernhard Walle <walle@corscience.de>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: GPMC: Export gpmc_enable_hwecc and gpmc_calculate_ecc
Date: Mon, 5 Mar 2012 13:58:54 -0800 [thread overview]
Message-ID: <20120305215853.GW12083@atomide.com> (raw)
In-Reply-To: <1329489859-23929-1-git-send-email-walle@corscience.de>
* Bernhard Walle <walle@corscience.de> [120217 06:15]:
> To be able to compile kernel/drivers/mtd/nand/omap2.ko as module, that
> two symbols need to be exported. Otherwise, I get following error
> message
>
> ERROR: "gpmc_calculate_ecc" [drivers/mtd/nand/omap2.ko] undefined!
> ERROR: "gpmc_enable_hwecc" [drivers/mtd/nand/omap2.ko] undefined!
>
> Signed-off-by: Bernhard Walle <walle@corscience.de>
Thanks applying into fixes-non-critical-part2.
Regards,
Tony
> ---
> arch/arm/mach-omap2/gpmc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index dfffbbf..00d5108 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -888,6 +888,7 @@ int gpmc_enable_hwecc(int cs, int mode, int dev_width, int ecc_size)
> gpmc_write_reg(GPMC_ECC_CONFIG, val);
> return 0;
> }
> +EXPORT_SYMBOL_GPL(gpmc_enable_hwecc);
>
> /**
> * gpmc_calculate_ecc - generate non-inverted ecc bytes
> @@ -918,3 +919,4 @@ int gpmc_calculate_ecc(int cs, const u_char *dat, u_char *ecc_code)
> gpmc_ecc_used = -EINVAL;
> return 0;
> }
> +EXPORT_SYMBOL_GPL(gpmc_calculate_ecc);
> --
> 1.7.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: GPMC: Export gpmc_enable_hwecc and gpmc_calculate_ecc
Date: Mon, 5 Mar 2012 13:58:54 -0800 [thread overview]
Message-ID: <20120305215853.GW12083@atomide.com> (raw)
In-Reply-To: <1329489859-23929-1-git-send-email-walle@corscience.de>
* Bernhard Walle <walle@corscience.de> [120217 06:15]:
> To be able to compile kernel/drivers/mtd/nand/omap2.ko as module, that
> two symbols need to be exported. Otherwise, I get following error
> message
>
> ERROR: "gpmc_calculate_ecc" [drivers/mtd/nand/omap2.ko] undefined!
> ERROR: "gpmc_enable_hwecc" [drivers/mtd/nand/omap2.ko] undefined!
>
> Signed-off-by: Bernhard Walle <walle@corscience.de>
Thanks applying into fixes-non-critical-part2.
Regards,
Tony
> ---
> arch/arm/mach-omap2/gpmc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index dfffbbf..00d5108 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -888,6 +888,7 @@ int gpmc_enable_hwecc(int cs, int mode, int dev_width, int ecc_size)
> gpmc_write_reg(GPMC_ECC_CONFIG, val);
> return 0;
> }
> +EXPORT_SYMBOL_GPL(gpmc_enable_hwecc);
>
> /**
> * gpmc_calculate_ecc - generate non-inverted ecc bytes
> @@ -918,3 +919,4 @@ int gpmc_calculate_ecc(int cs, const u_char *dat, u_char *ecc_code)
> gpmc_ecc_used = -EINVAL;
> return 0;
> }
> +EXPORT_SYMBOL_GPL(gpmc_calculate_ecc);
> --
> 1.7.9.1
>
next prev parent reply other threads:[~2012-03-05 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 14:44 [PATCH] ARM: OMAP2+: GPMC: Export gpmc_enable_hwecc and gpmc_calculate_ecc Bernhard Walle
2012-02-17 14:44 ` Bernhard Walle
2012-03-05 21:58 ` Tony Lindgren [this message]
2012-03-05 21:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305215853.GW12083@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=walle@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.