From: Nishanth Menon <nm@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@ti.com, paul@pwsan.com,
Vishwanath BS <vishwanath.bs@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv4 2/6] ARM: OMAP3 PM: Move IO Daisychain function to omap3 prm file
Date: Mon, 5 Mar 2012 23:44:44 -0600 [thread overview]
Message-ID: <20120306054443.GA5670@kobold> (raw)
In-Reply-To: <1330701475-22576-3-git-send-email-t-kristo@ti.com>
On 17:17-20120302, Tero Kristo wrote:
> From: Vishwanath BS <vishwanath.bs@ti.com>
>
> Since IO Daisychain modifies only PRM registers, it makes sense to move
> it to PRM File. Also changed the timeout value for IO chain enable to
> 100us and added a wait for status disable at the end.
>
[...]
> +/*
> + * Maximum time(us) it takes to output the signal WUCLKOUT of the last pad of
> + * the I/O ring after asserting WUCLKIN high
> + */
> +#define MAX_IOPAD_LATCH_TIME 100
> +
> +/* OMAP3 Daisychain enable sequence */
> +void omap3_trigger_io_chain(void)
> +{
> + int i = 0;
> +
> + omap2_prm_set_mod_reg_bits(OMAP3430_EN_IO_CHAIN_MASK, WKUP_MOD,
> + PM_WKEN);
> + /* Do a readback to assure write has been done */
> + omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN);
> +
> + omap_test_timeout(((omap2_prm_read_mod_reg(WKUP_MOD, PM_WKST) &
> + OMAP3430_ST_IO_CHAIN_MASK) == 1),
umm
arch/arm/mach-omap2/prm-regbits-34xx.h:#define OMAP3430_ST_IO_CHAIN_MASK
(1 << 16)
(reg & (1 << 16)) == 1
will ever be true?
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 2/6] ARM: OMAP3 PM: Move IO Daisychain function to omap3 prm file
Date: Mon, 5 Mar 2012 23:44:44 -0600 [thread overview]
Message-ID: <20120306054443.GA5670@kobold> (raw)
In-Reply-To: <1330701475-22576-3-git-send-email-t-kristo@ti.com>
On 17:17-20120302, Tero Kristo wrote:
> From: Vishwanath BS <vishwanath.bs@ti.com>
>
> Since IO Daisychain modifies only PRM registers, it makes sense to move
> it to PRM File. Also changed the timeout value for IO chain enable to
> 100us and added a wait for status disable at the end.
>
[...]
> +/*
> + * Maximum time(us) it takes to output the signal WUCLKOUT of the last pad of
> + * the I/O ring after asserting WUCLKIN high
> + */
> +#define MAX_IOPAD_LATCH_TIME 100
> +
> +/* OMAP3 Daisychain enable sequence */
> +void omap3_trigger_io_chain(void)
> +{
> + int i = 0;
> +
> + omap2_prm_set_mod_reg_bits(OMAP3430_EN_IO_CHAIN_MASK, WKUP_MOD,
> + PM_WKEN);
> + /* Do a readback to assure write has been done */
> + omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN);
> +
> + omap_test_timeout(((omap2_prm_read_mod_reg(WKUP_MOD, PM_WKST) &
> + OMAP3430_ST_IO_CHAIN_MASK) == 1),
umm
arch/arm/mach-omap2/prm-regbits-34xx.h:#define OMAP3430_ST_IO_CHAIN_MASK
(1 << 16)
(reg & (1 << 16)) == 1
will ever be true?
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2012-03-06 5:44 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 15:17 [PATCHv4 0/6] ARM: OMAP3+: IO daisychain support fixes Tero Kristo
2012-03-02 15:17 ` Tero Kristo
2012-03-02 15:17 ` [PATCHv4 1/6] ARM: OMAP3 PM: correct enable/disable of daisy io chain Tero Kristo
2012-03-02 15:17 ` Tero Kristo
2012-03-06 2:59 ` Paul Walmsley
2012-03-06 2:59 ` Paul Walmsley
2012-03-06 3:53 ` Rajendra Nayak
2012-03-06 3:53 ` Rajendra Nayak
2012-03-06 3:59 ` Rajendra Nayak
2012-03-06 3:59 ` Rajendra Nayak
2012-03-06 4:13 ` Paul Walmsley
2012-03-06 4:13 ` Paul Walmsley
2012-03-06 4:32 ` Rajendra Nayak
2012-03-06 4:32 ` Rajendra Nayak
2012-03-02 15:17 ` [PATCHv4 2/6] ARM: OMAP3 PM: Move IO Daisychain function to omap3 prm file Tero Kristo
2012-03-02 15:17 ` Tero Kristo
2012-03-06 5:44 ` Nishanth Menon [this message]
2012-03-06 5:44 ` Nishanth Menon
2012-03-06 6:00 ` Rajendra Nayak
2012-03-06 6:00 ` Rajendra Nayak
2012-03-06 8:41 ` Tero Kristo
2012-03-06 8:41 ` Tero Kristo
2012-03-02 15:17 ` [PATCHv4 3/6] ARM: OMAP4 PM: Add IO Daisychain support Tero Kristo
2012-03-02 15:17 ` Tero Kristo
2012-03-02 15:17 ` [PATCHv4 4/6] ARM: OMAP3+: PRM: Enable IO wake up Tero Kristo
2012-03-02 15:17 ` Tero Kristo
2012-03-06 4:21 ` Paul Walmsley
2012-03-06 4:21 ` Paul Walmsley
2012-03-06 4:50 ` Rajendra Nayak
2012-03-06 4:50 ` Rajendra Nayak
2012-03-06 4:56 ` Rajendra Nayak
2012-03-06 4:56 ` Rajendra Nayak
2012-03-06 8:44 ` Tero Kristo
2012-03-06 8:44 ` Tero Kristo
2012-03-06 14:10 ` Tero Kristo
2012-03-06 14:10 ` Tero Kristo
2012-03-02 15:17 ` [PATCHv4 5/6] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Tero Kristo
2012-03-02 15:17 ` Tero Kristo
2012-03-06 4:02 ` Paul Walmsley
2012-03-06 4:02 ` Paul Walmsley
2012-03-06 4:21 ` Rajendra Nayak
2012-03-06 4:21 ` Rajendra Nayak
2012-03-06 8:51 ` Tero Kristo
2012-03-06 8:51 ` Tero Kristo
2012-03-02 15:17 ` [PATCHv4 6/6] ARM: OMAP3 PM: Remove IO Daisychain control from cpuidle Tero Kristo
2012-03-02 15:17 ` Tero Kristo
2012-03-05 10:01 ` [PATCHv4 0/6] ARM: OMAP3+: IO daisychain support fixes Rajendra Nayak
2012-03-05 10:01 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306054443.GA5670@kobold \
--to=nm@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.