From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: dapm: Allow DAPM registers to be unsigned int
Date: Thu, 8 Mar 2012 13:21:50 +0000 [thread overview]
Message-ID: <20120308132149.GN3638@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAOMZO5DHp3HegJ3C_HFj+M=amd6LdTtUcaXigG=ZpmPHG_TJ9g@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 465 bytes --]
On Thu, Mar 08, 2012 at 09:52:20AM -0300, Fabio Estevam wrote:
> On Thu, Mar 8, 2012 at 9:48 AM, Mark Brown
> > - short reg; /* negative reg = no direct dapm */
> > + unsigned int reg; /* negative reg = no direct dapm */
> Maybe you should update the comment now that this is unsigned int.
Bah, humbug - no, it needs to be signed int and we don't support the
full 32 bits.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-03-08 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 12:48 [PATCH] ASoC: dapm: Allow DAPM registers to be unsigned int Mark Brown
2012-03-08 12:52 ` Fabio Estevam
2012-03-08 13:10 ` Lars-Peter Clausen
2012-03-08 13:21 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308132149.GN3638@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=festevam@gmail.com \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.