All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	patches@opensource.wolfsonmicro.com, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: dapm: Allow DAPM registers to be unsigned int
Date: Thu, 08 Mar 2012 14:10:23 +0100	[thread overview]
Message-ID: <4F58AFBF.3060609@metafoo.de> (raw)
In-Reply-To: <CAOMZO5DHp3HegJ3C_HFj+M=amd6LdTtUcaXigG=ZpmPHG_TJ9g@mail.gmail.com>

On 03/08/2012 01:52 PM, Fabio Estevam wrote:
> On Thu, Mar 8, 2012 at 9:48 AM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
> 
>>        /* dapm control */
>> -       short reg;                                              /* negative reg = no direct dapm */
>> +       unsigned int reg;                       /* negative reg = no direct dapm */
> 
> Maybe you should update the comment now that this is unsigned int.

There are also a few places in soc-dapm.c which check for reg >= 0 to handle
SND_SOC_NOPM, those need to be updated as well.

  reply	other threads:[~2012-03-08 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 12:48 [PATCH] ASoC: dapm: Allow DAPM registers to be unsigned int Mark Brown
2012-03-08 12:52 ` Fabio Estevam
2012-03-08 13:10   ` Lars-Peter Clausen [this message]
2012-03-08 13:21   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F58AFBF.3060609@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=festevam@gmail.com \
    --cc=lrg@ti.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.