From: Greg KH <gregkh@linuxfoundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 6/6] vt: push the tty_lock down into the map handling
Date: Thu, 8 Mar 2012 11:14:36 -0800 [thread overview]
Message-ID: <20120308191436.GA30341@kroah.com> (raw)
In-Reply-To: <20120302150012.32320.70608.stgit@bob.linux.org.uk>
On Fri, Mar 02, 2012 at 03:00:14PM +0000, Alan Cox wrote:
> From: Alan Cox <alan@linux.intel.com>
>
> When we do this it becomes clear the lock we should be holding is the vc
> lock, and in fact many of our other helpers are properly invoked this way.
>
> We don't at this point guarantee not to race the keyboard code but the results
> of that appear harmless and that was true before we started as well.
>
> We now have no users of tty_lock in the console driver...
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/tty/vt/consolemap.c | 119 ++++++++++++++++++++++++++++++++-----------
> drivers/tty/vt/vt_ioctl.c | 25 ++-------
> include/linux/vt_kern.h | 1
> 3 files changed, 93 insertions(+), 52 deletions(-)
>
With this patch applied, I get the following build error:
drivers/tty/vt/consolemap.c: In function ‘con_set_trans_old’:
drivers/tty/vt/consolemap.c:315:2: error: implicit declaration of function ‘console_lock’ [-Werror=implicit-function-declaration]
drivers/tty/vt/consolemap.c:323:2: error: implicit declaration of function ‘console_unlock’ [-Werror=implicit-function-declaration]
what went wrong?
I've applied the first 5 in this series to my tree now, but not this
one.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 6/6] vt: push the tty_lock down into the map handling
Date: Thu, 8 Mar 2012 11:14:36 -0800 [thread overview]
Message-ID: <20120308191436.GA30341@kroah.com> (raw)
In-Reply-To: <20120302150012.32320.70608.stgit@bob.linux.org.uk>
On Fri, Mar 02, 2012 at 03:00:14PM +0000, Alan Cox wrote:
> From: Alan Cox <alan@linux.intel.com>
>
> When we do this it becomes clear the lock we should be holding is the vc
> lock, and in fact many of our other helpers are properly invoked this way.
>
> We don't at this point guarantee not to race the keyboard code but the results
> of that appear harmless and that was true before we started as well.
>
> We now have no users of tty_lock in the console driver...
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/tty/vt/consolemap.c | 119 ++++++++++++++++++++++++++++++++-----------
> drivers/tty/vt/vt_ioctl.c | 25 ++-------
> include/linux/vt_kern.h | 1
> 3 files changed, 93 insertions(+), 52 deletions(-)
>
With this patch applied, I get the following build error:
drivers/tty/vt/consolemap.c: In function ‘con_set_trans_old’:
drivers/tty/vt/consolemap.c:315:2: error: implicit declaration of function ‘console_lock’ [-Werror=implicit-function-declaration]
drivers/tty/vt/consolemap.c:323:2: error: implicit declaration of function ‘console_unlock’ [-Werror=implicit-function-declaration]
what went wrong?
I've applied the first 5 in this series to my tree now, but not this
one.
thanks,
greg k-h
next prev parent reply other threads:[~2012-03-08 19:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 14:58 [PATCH 0/6] Series short description Alan Cox
2012-03-02 14:59 ` [PATCH 1/6] vt: sort out locking for font handling Alan Cox
2012-03-02 14:59 ` [PATCH 2/6] vt: push down the tty lock so we can see what is left to tackle Alan Cox
2012-03-02 14:59 ` [PATCH 3/6] vt: push down tioclinux cases Alan Cox
2012-03-02 14:59 ` [PATCH 4/6] vt: waitevent is self locked so drop the tty_lock Alan Cox
2012-03-02 15:00 ` [PATCH 5/6] vt: tackle the main part of the selection logic Alan Cox
2012-03-02 15:00 ` [PATCH 6/6] vt: push the tty_lock down into the map handling Alan Cox
2012-03-08 19:14 ` Greg KH [this message]
2012-03-08 19:14 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-03-01 19:49 [PATCH 0/6] Remove tty_lock from the console drivers Alan Cox
2012-03-01 19:52 ` [PATCH 6/6] vt: push the tty_lock down into the map handling Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308191436.GA30341@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.