From: Grant Likely <grant.likely@secretlab.ca>
To: wharms-fPG8STNUNVg@public.gmane.org,
Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] spi: release lock on error path in spi_pump_messages()
Date: Sun, 11 Mar 2012 02:43:07 +0000 [thread overview]
Message-ID: <20120311024307.AA5E33E0950@localhost> (raw)
In-Reply-To: <4F5B2113.3060103-fPG8STNUNVg@public.gmane.org>
On Sat, 10 Mar 2012 10:38:27 +0100, walter harms <wharms@bfs.de> wrote:
>
>
> Am 10.03.2012 09:57, schrieb Dan Carpenter:
> > We should release the lock here and enable IRQs before returning.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> > index 5ae1e84..ab1bdce 100644
> > --- a/drivers/spi/spi.c
> > +++ b/drivers/spi/spi.c
> > @@ -535,6 +535,7 @@ static void spi_pump_messages(struct kthread_work *work)
> > if (ret) {
> > dev_err(&master->dev,
> > "failed to unprepare transfer hardware\n");
> > + spin_unlock_irqrestore(&master->queue_lock, flags);
> > return;
> > }
> > }
>
>
> hi Dan,
> do you want to protect dev_err() by a spn_lock ?
Applied, after moving unlock above the dev_err.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: wharms-fPG8STNUNVg@public.gmane.org,
Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] spi: release lock on error path in spi_pump_messages()
Date: Sat, 10 Mar 2012 19:43:07 -0700 [thread overview]
Message-ID: <20120311024307.AA5E33E0950@localhost> (raw)
In-Reply-To: <4F5B2113.3060103-fPG8STNUNVg@public.gmane.org>
On Sat, 10 Mar 2012 10:38:27 +0100, walter harms <wharms-fPG8STNUNVg@public.gmane.org> wrote:
>
>
> Am 10.03.2012 09:57, schrieb Dan Carpenter:
> > We should release the lock here and enable IRQs before returning.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> >
> > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> > index 5ae1e84..ab1bdce 100644
> > --- a/drivers/spi/spi.c
> > +++ b/drivers/spi/spi.c
> > @@ -535,6 +535,7 @@ static void spi_pump_messages(struct kthread_work *work)
> > if (ret) {
> > dev_err(&master->dev,
> > "failed to unprepare transfer hardware\n");
> > + spin_unlock_irqrestore(&master->queue_lock, flags);
> > return;
> > }
> > }
>
>
> hi Dan,
> do you want to protect dev_err() by a spn_lock ?
Applied, after moving unlock above the dev_err.
g.
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: wharms@bfs.de, Dan Carpenter <dan.carpenter@oracle.com>
Cc: spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] spi: release lock on error path in spi_pump_messages()
Date: Sat, 10 Mar 2012 19:43:07 -0700 [thread overview]
Message-ID: <20120311024307.AA5E33E0950@localhost> (raw)
In-Reply-To: <4F5B2113.3060103@bfs.de>
On Sat, 10 Mar 2012 10:38:27 +0100, walter harms <wharms@bfs.de> wrote:
>
>
> Am 10.03.2012 09:57, schrieb Dan Carpenter:
> > We should release the lock here and enable IRQs before returning.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> > index 5ae1e84..ab1bdce 100644
> > --- a/drivers/spi/spi.c
> > +++ b/drivers/spi/spi.c
> > @@ -535,6 +535,7 @@ static void spi_pump_messages(struct kthread_work *work)
> > if (ret) {
> > dev_err(&master->dev,
> > "failed to unprepare transfer hardware\n");
> > + spin_unlock_irqrestore(&master->queue_lock, flags);
> > return;
> > }
> > }
>
>
> hi Dan,
> do you want to protect dev_err() by a spn_lock ?
Applied, after moving unlock above the dev_err.
g.
next prev parent reply other threads:[~2012-03-11 2:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-10 8:57 [patch] spi: release lock on error path in spi_pump_messages() Dan Carpenter
2012-03-10 8:57 ` Dan Carpenter
2012-03-10 8:57 ` Dan Carpenter
[not found] ` <20120310085729.GB4647-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-03-10 9:38 ` walter harms
2012-03-10 9:38 ` walter harms
2012-03-10 9:38 ` walter harms
[not found] ` <4F5B2113.3060103-fPG8STNUNVg@public.gmane.org>
2012-03-11 2:43 ` Grant Likely [this message]
2012-03-11 2:43 ` Grant Likely
2012-03-11 2:43 ` Grant Likely
2012-03-11 6:20 ` Dan Carpenter
2012-03-11 6:20 ` Dan Carpenter
2012-03-11 13:02 ` Grant Likely
2012-03-11 13:02 ` Grant Likely
2012-03-11 13:02 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311024307.AA5E33E0950@localhost \
--to=grant.likely@secretlab.ca \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=wharms-fPG8STNUNVg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.