From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Philippe Rétornaz" <philippe.retornaz@epfl.ch>
Cc: juergen.lambrecht@gmail.com, s.hauer@pengutronix.de,
festevam@gmail.com, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] Add imx3sound sound support.
Date: Sun, 11 Mar 2012 11:40:15 +0000 [thread overview]
Message-ID: <20120311114014.GB3233@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1331304916-4724-3-git-send-email-philippe.retornaz@epfl.ch>
[-- Attachment #1.1: Type: text/plain, Size: 402 bytes --]
On Fri, Mar 09, 2012 at 03:55:14PM +0100, Philippe Rétornaz wrote:
> +static int imx3sound_hifi_hw_free(struct snd_pcm_substream *substream)
> +{
> + return 0;
> +}
Remove all empty functions.
> + imx3sound_snd_device = platform_device_alloc("soc-audio", -1);
> + if (!imx3sound_snd_device)
> + return -ENOMEM;
No soc-audio usage, use snd_soc_register_card() from a platform device.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] Add imx3sound sound support.
Date: Sun, 11 Mar 2012 11:40:15 +0000 [thread overview]
Message-ID: <20120311114014.GB3233@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1331304916-4724-3-git-send-email-philippe.retornaz@epfl.ch>
On Fri, Mar 09, 2012 at 03:55:14PM +0100, Philippe R?tornaz wrote:
> +static int imx3sound_hifi_hw_free(struct snd_pcm_substream *substream)
> +{
> + return 0;
> +}
Remove all empty functions.
> + imx3sound_snd_device = platform_device_alloc("soc-audio", -1);
> + if (!imx3sound_snd_device)
> + return -ENOMEM;
No soc-audio usage, use snd_soc_register_card() from a platform device.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120311/671bbcbf/attachment-0001.sig>
next prev parent reply other threads:[~2012-03-11 11:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 14:55 [PATCH 0/4] mc13783 sound support Philippe Rétornaz
2012-03-09 14:55 ` Philippe Rétornaz
2012-03-09 14:55 ` [PATCH 1/4] add a mc13783 codec driver Philippe Rétornaz
2012-03-09 14:55 ` Philippe Rétornaz
2012-03-09 14:55 ` [PATCH 2/4] Add imx3sound sound support Philippe Rétornaz
2012-03-09 14:55 ` Philippe Rétornaz
2012-03-09 14:55 ` [PATCH 3/4] mx31moboard: Add ssi configuration Philippe Rétornaz
2012-03-09 14:55 ` Philippe Rétornaz
2012-03-09 14:55 ` [PATCH 4/4] imx31pdk: Add sound support Philippe Rétornaz
2012-03-09 14:55 ` Philippe Rétornaz
2012-03-11 11:41 ` [PATCH 3/4] mx31moboard: Add ssi configuration Mark Brown
2012-03-11 11:41 ` Mark Brown
2012-03-11 14:13 ` Fabio Estevam
2012-03-11 14:13 ` Fabio Estevam
2012-03-11 11:40 ` Mark Brown [this message]
2012-03-11 11:40 ` [PATCH 2/4] Add imx3sound sound support Mark Brown
2012-03-11 14:59 ` Fabio Estevam
2012-03-11 14:59 ` Fabio Estevam
2012-03-12 8:11 ` Philippe Rétornaz
2012-03-12 8:11 ` Philippe Rétornaz
2012-03-11 11:38 ` [PATCH 1/4] add a mc13783 codec driver Mark Brown
2012-03-11 11:38 ` Mark Brown
2012-03-12 8:11 ` Philippe Rétornaz
2012-03-12 8:11 ` Philippe Rétornaz
2012-03-12 10:58 ` Mark Brown
2012-03-12 10:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311114014.GB3233@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=festevam@gmail.com \
--cc=juergen.lambrecht@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=philippe.retornaz@epfl.ch \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.