From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Hans Schillstrom <hans@schillstrom.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: linux-next: Tree for Mar 9 (netfilter)
Date: Sun, 11 Mar 2012 17:58:02 +0100 [thread overview]
Message-ID: <20120311165802.GB27265@1984> (raw)
In-Reply-To: <20120311165630.GA27265@1984>
Hi Hans,
On Sun, Mar 11, 2012 at 05:14:01PM +0100, Hans Schillstrom wrote:
> >Perhaps I'm missing anything but either way (IPv6 as module or
> >built-in) the symbol is still defined. With my patch applied, xt_LOG
> >now depends on IP6_NF_IPTABLES, which depends on IPV6.
> >
> >Moreover we've got other xt_ target and matches that contain both IPv4
> >and IPv6 support that don't require this.
> >
> >Let me know.
>
> if you compile ipv6 as a module and xt_LOG as builtin (=y) there is a missing ref to `ip6t_ext_hdr' at link time ...
ip6t_ext_hdr is defined by ip6_tables:
net/ipv6/netfilter/ip6_tables.c:ip6t_ext_hdr(u8 nexthdr)
AFAICS the dependency should rely on CONFIG_IP6_NF_IPTABLES.
An alternative is to define ip6t_ext_hdr as static inline in
include/linux/netfilter_ipv6/ip6_tables.h, it's fairly small and it's
invoked in the typical packet path if this LOG is used.
> What I did was to resolve that issue i.e. force xt_LOG to be a module if ipv6 is a module
Thanks for reporting this.
next parent reply other threads:[~2012-03-11 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <giupeu1.0f6dad72b5ddb117e753f5f660263a5d@obelix.schillstrom.com>
[not found] ` <20120311165630.GA27265@1984>
2012-03-11 16:58 ` Pablo Neira Ayuso [this message]
2012-03-11 12:37 Re[2]: linux-next: Tree for Mar 9 (netfilter) Hans Schillstrom
2012-03-11 15:52 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2012-03-09 8:11 linux-next: Tree for Mar 9 Stephen Rothwell
2012-03-09 20:30 ` linux-next: Tree for Mar 9 (netfilter) Randy Dunlap
2012-03-10 11:21 ` Pablo Neira Ayuso
2012-03-10 16:45 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311165802.GB27265@1984 \
--to=pablo@netfilter.org \
--cc=hans@schillstrom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.