From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 1/4] USB: OHCI-HCD: Rename ohci-pnx4008 to ohci-nxp
Date: Mon, 12 Mar 2012 08:46:28 +0000 [thread overview]
Message-ID: <201203120846.29070.arnd@arndb.de> (raw)
In-Reply-To: <1331463219-23293-2-git-send-email-stigge@antcom.de>
On Sunday 11 March 2012, Roland Stigge wrote:
> Since this driver is compatible with several NXP devices, the driver is renamed
> accordingly. Please combine with the following patch which also changes the
> respective symbol names.
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
>
Hi Roland,
As a general comment, it's helpful to use the "-M" flag to git-format-patch
whenever you rename files, because that makes it obvious whether you have
changed anything in the file or not.
> --- /dev/null
> +++ linux-2.6/drivers/usb/host/ohci-nxp.c
> @@ -0,0 +1,453 @@
> +/*
> + * drivers/usb/host/ohci-pnx4008.c
> + *
> + * driver for Philips PNX4008 USB Host
> + *
I think your second patch does not change this comment and probably should.
Just remove the file name from the comment because that one is generally
not helpful.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Roland Stigge <stigge@antcom.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
w.sang@pengutronix.de, kevin.wells@nxp.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/4] USB: OHCI-HCD: Rename ohci-pnx4008 to ohci-nxp
Date: Mon, 12 Mar 2012 08:46:28 +0000 [thread overview]
Message-ID: <201203120846.29070.arnd@arndb.de> (raw)
In-Reply-To: <1331463219-23293-2-git-send-email-stigge@antcom.de>
On Sunday 11 March 2012, Roland Stigge wrote:
> Since this driver is compatible with several NXP devices, the driver is renamed
> accordingly. Please combine with the following patch which also changes the
> respective symbol names.
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
>
Hi Roland,
As a general comment, it's helpful to use the "-M" flag to git-format-patch
whenever you rename files, because that makes it obvious whether you have
changed anything in the file or not.
> --- /dev/null
> +++ linux-2.6/drivers/usb/host/ohci-nxp.c
> @@ -0,0 +1,453 @@
> +/*
> + * drivers/usb/host/ohci-pnx4008.c
> + *
> + * driver for Philips PNX4008 USB Host
> + *
I think your second patch does not change this comment and probably should.
Just remove the file name from the comment because that one is generally
not helpful.
Arnd
next prev parent reply other threads:[~2012-03-12 8:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 10:53 [PATCH v7 0/4] USB: OHCI-HCD: Support for LPC32xx Roland Stigge
2012-03-11 10:53 ` Roland Stigge
2012-03-11 10:53 ` [PATCH v7 1/4] USB: OHCI-HCD: Rename ohci-pnx4008 to ohci-nxp Roland Stigge
2012-03-11 10:53 ` Roland Stigge
2012-03-12 8:46 ` Arnd Bergmann [this message]
2012-03-12 8:46 ` Arnd Bergmann
2012-03-11 10:53 ` [PATCH v7 2/4] USB: ohci-nxp: Rename symbols from pnx4008 to nxp Roland Stigge
2012-03-11 10:53 ` Roland Stigge
2012-03-11 10:53 ` [PATCH v7 3/4] USB: ohci-nxp: Support for LPC32xx Roland Stigge
2012-03-11 10:53 ` Roland Stigge
2012-03-11 10:53 ` [PATCH v7 4/4] USB: ohci-nxp: Remove i2c_write(), use smbus Roland Stigge
2012-03-11 10:53 ` Roland Stigge
2012-03-12 19:16 ` Wolfram Sang
2012-03-12 19:16 ` Wolfram Sang
2012-03-12 19:02 ` [PATCH v7 0/4] USB: OHCI-HCD: Support for LPC32xx Wolfram Sang
2012-03-12 19:02 ` Wolfram Sang
2012-03-12 21:52 ` Roland Stigge
2012-03-12 21:52 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203120846.29070.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.