All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: (w83627ehf) Describe undocumented pwm attributes
Date: Tue, 13 Mar 2012 10:46:15 +0000	[thread overview]
Message-ID: <20120313104615.GC31363@ericsson.com> (raw)
In-Reply-To: <1328806643-25371-1-git-send-email-guenter.roeck@ericsson.com>

On Tue, Mar 13, 2012 at 04:07:53AM -0400, Jean Delvare wrote:
> On Thu, 9 Feb 2012 08:57:23 -0800, Guenter Roeck wrote:
> > Add description of pwm[1-4]_start_output, pwm[1-4]_step_output,
> > pwm[1-4]_stop_output, and pwm[1-4]_max_output attributes to driver
> > documentation.
> 
> Would be nice to have these standardized at some point... But meanwhile
> I agree it's best described in the driver documentation file.
> 
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > ---
> >  Documentation/hwmon/w83627ehf |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/Documentation/hwmon/w83627ehf b/Documentation/hwmon/w83627ehf
> > index 3f44dbd..ea75fe4 100644
> > --- a/Documentation/hwmon/w83627ehf
> > +++ b/Documentation/hwmon/w83627ehf
> > @@ -143,6 +143,11 @@ pwm[1-4]_min_output - minimum fan speed (range 1 - 255), when the temperature
> >  pwm[1-4]_stop_time  - how many milliseconds [ms] must elapse to switch
> >                        corresponding fan off. (when the temperature was below
> >                        defined range).
> > +pwm[1-4]_start_output-minimum fan speed (range 1 - 255) when spinning up
> > +pwm[1-4]_step_output- rate of fan speed change (1 - 255)
> > +pwm[1-4]_stop_output- minimum fan speed (range 1 - 255) when spinning down
> > +pwm[1-4]_max_output - maximum fan speed (range 1 - 255), when the temperature
> > +                      is above defined range.
> >  
> >  Note: last two functions are influenced by other control bits, not yet exported
> 
> "last two" should probably become "last six".
> 
> >        by the driver, so a change might not have any effect.
> 
> Other than this:
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>
> 
Thanks, updated and applied.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2012-03-13 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 16:57 [lm-sensors] [PATCH 2/2] hwmon: (w83627ehf) Describe undocumented pwm attributes Guenter Roeck
2012-03-13  8:07 ` Jean Delvare
2012-03-13 10:46 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313104615.GC31363@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.