Is this bug ? msg->complete() double call on s3c64xx.c ?

Is this bug ? msg->complete() double call on s3c64xx.c ?

[kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ]

Hi SPI ML, Mark

Now I'm studying SPI core message queue by checking spi-s3c64xx.c.

And I noticed that strange code on
ad2a99af0d7242726723575efaffa1625664b384
(spi/s3c64xx: Convert to using core message queue)

current spi-s3c64xx.c :: s3c64xx_spi_transfer_one_message() is

-----------------------------------------------------------------------
static int s3c64xx_spi_transfer_one_message(struct spi_master *master,
					    struct spi_message *msg)
{
...
	if (msg->complete)
		msg->complete(msg->context);

	spi_finalize_current_message(master);

	return 0;
}
-----------------------------------------------------------------------

But I think spi_finalize_current_message() itself will call msg->complete().
Is this double call ?
I'm not sure.

msg->complete() of spi-pl022.c was removed by
ffbbdd21329f3e15eeca6df2d4bc11c04d9d91c0
(spi: create a message queueing infrastructure)

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d

[PATCH] spi: s3c64xx: remove unnecessary callback msg->complete

[Kuninori Morimoto]

msg->complete will be called in spi_finalize_current_message().

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-s3c64xx.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index c40d118..c5e5aab 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -764,9 +764,6 @@ out:
 
 	msg->status = status;
 
-	if (msg->complete)
-		msg->complete(msg->context);
-
 	spi_finalize_current_message(master);
 
 	return 0;
-- 
1.7.5.4


------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/

Re: [PATCH] spi: s3c64xx: remove unnecessary callback msg->complete

[Grant Likely]

On Wed, 14 Mar 2012 16:59:59 +0000, Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> wrote:
> On Tue, Mar 13, 2012 at 05:19:05PM -0700, Kuninori Morimoto wrote:
> > msg->complete will be called in spi_finalize_current_message().
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> 
> Reviewed-by: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>

Applied, thanks

g.

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure