All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Boojin Kim <boojin.kim@samsung.com>,
	Kyoungil Kim <ki0351.kim@samsung.com>
Cc: spi-devel-general@lists.sourceforge.net,
	linux-samsung-soc@vger.kernel.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] spi: s3c64xx: Fix build
Date: Thu, 15 Mar 2012 03:32:33 -0600	[thread overview]
Message-ID: <20120315093233.7F7ED3E0648@localhost> (raw)
In-Reply-To: <1331743934-23577-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Wed, 14 Mar 2012 16:52:14 +0000, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> Commit 054ebc (spi: Compatibility with direction which is used in samsung
> DMA operation) does not build as one hunk adds a brace to the first branch
> of an if statement without adding at least the correspoding close. Remove
> the unwanted brace.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Applied, thanks.

g.

> ---
>  drivers/spi/spi-s3c64xx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index c40d118..3180100 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -264,7 +264,7 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
>  	struct s3c64xx_spi_driver_data *sdd;
>  	struct samsung_dma_prep_info info;
>  
> -	if (dma->direction == DMA_DEV_TO_MEM) {
> +	if (dma->direction == DMA_DEV_TO_MEM)
>  		sdd = container_of((void *)dma,
>  			struct s3c64xx_spi_driver_data, rx_dma);
>  	else
> -- 
> 1.7.9.1
> 

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.

WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Boojin Kim <boojin.kim@samsung.com>,
	Kyoungil Kim <ki0351.kim@samsung.com>
Cc: spi-devel-general@lists.sourceforge.net,
	linux-samsung-soc@vger.kernel.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] spi: s3c64xx: Fix build
Date: Thu, 15 Mar 2012 03:32:33 -0600	[thread overview]
Message-ID: <20120315093233.7F7ED3E0648@localhost> (raw)
In-Reply-To: <1331743934-23577-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Wed, 14 Mar 2012 16:52:14 +0000, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> Commit 054ebc (spi: Compatibility with direction which is used in samsung
> DMA operation) does not build as one hunk adds a brace to the first branch
> of an if statement without adding at least the correspoding close. Remove
> the unwanted brace.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Applied, thanks.

g.

> ---
>  drivers/spi/spi-s3c64xx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index c40d118..3180100 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -264,7 +264,7 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
>  	struct s3c64xx_spi_driver_data *sdd;
>  	struct samsung_dma_prep_info info;
>  
> -	if (dma->direction == DMA_DEV_TO_MEM) {
> +	if (dma->direction == DMA_DEV_TO_MEM)
>  		sdd = container_of((void *)dma,
>  			struct s3c64xx_spi_driver_data, rx_dma);
>  	else
> -- 
> 1.7.9.1
> 

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.

  reply	other threads:[~2012-03-15 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 16:52 [PATCH] spi: s3c64xx: Fix build Mark Brown
2012-03-15  9:32 ` Grant Likely [this message]
2012-03-15  9:32   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120315093233.7F7ED3E0648@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=boojin.kim@samsung.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=ki0351.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.