From: Shaohua Li <shli@fusionio.com>
To: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Cc: neilb@suse.de, axboe@kernel.dk, vgoyal@redhat.com,
martin.petersen@oracle.com, Shaohua Li <shli@fusionio.com>
Subject: [patch v2 2/6] blk: dont allow discard request merge temporarily
Date: Fri, 16 Mar 2012 15:32:15 +0800 [thread overview]
Message-ID: <20120316073512.485027511@fusionio.com> (raw)
In-Reply-To: 20120316073213.656519005@fusionio.com
[-- Attachment #1: blk-discard-nomerge.patch --]
[-- Type: text/plain, Size: 1165 bytes --]
Didn't allow discard request merge temporarily, as SCSI layer isn't ready
for discard merge as Martin Petersen pointed out. This isn't fair for
non-scsi device, but looks this is the only way I can do currently.
We should have the same issue before, but maybe because discard merge is
very rare case. But now raid0/10 makes the merge quite possible, so we need
disable it explicitly.
Signed-off-by: Shaohua Li <shli@fusionio.com>
---
include/linux/blkdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/include/linux/blkdev.h
===================================================================
--- linux.orig/include/linux/blkdev.h 2012-03-14 09:20:06.787261188 +0800
+++ linux/include/linux/blkdev.h 2012-03-14 09:20:47.797261248 +0800
@@ -575,7 +575,7 @@ static inline void blk_clear_queue_full(
* it already be started by driver.
*/
#define RQ_NOMERGE_FLAGS \
- (REQ_NOMERGE | REQ_STARTED | REQ_SOFTBARRIER | REQ_FLUSH | REQ_FUA)
+ (REQ_NOMERGE | REQ_STARTED | REQ_SOFTBARRIER | REQ_FLUSH | REQ_FUA | REQ_DISCARD)
#define rq_mergeable(rq) \
(!((rq)->cmd_flags & RQ_NOMERGE_FLAGS) && \
(((rq)->cmd_flags & REQ_DISCARD) || \
next prev parent reply other threads:[~2012-03-16 7:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 7:32 [patch v2 0/6] Add TRIM support for raid linear/0/1/10 Shaohua Li
2012-03-16 7:32 ` [patch v2 1/6] block: makes bio_split support bio without data Shaohua Li
2012-03-16 7:32 ` Shaohua Li [this message]
2012-03-20 16:21 ` [patch v2 2/6] blk: dont allow discard request merge temporarily Vivek Goyal
2012-03-21 1:22 ` Shaohua Li
2012-03-21 12:14 ` [patch 1/2]block: handle merged discard request Shaohua Li
2012-03-22 2:32 ` Martin K. Petersen
2012-03-22 2:39 ` Shaohua Li
2012-03-22 2:53 ` Martin K. Petersen
2012-06-20 8:57 ` Christoph Hellwig
2012-06-22 3:46 ` Martin K. Petersen
2012-08-03 2:10 ` Shaohua Li
2012-08-18 3:06 ` Mike Snitzer
2012-08-18 3:47 ` Martin K. Petersen
2012-08-20 13:57 ` Mike Snitzer
2012-08-20 13:58 ` Christoph Hellwig
2012-08-20 14:12 ` Mike Snitzer
2012-08-20 14:15 ` Christoph Hellwig
2012-03-22 2:18 ` [patch v2 2/6] blk: dont allow discard request merge temporarily Martin K. Petersen
2012-03-22 2:33 ` Shaohua Li
2012-03-22 6:28 ` Christoph Hellwig
2012-03-16 7:32 ` [patch v2 3/6] md: linear supports TRIM Shaohua Li
2012-03-16 7:32 ` [patch v2 4/6] md: raid 0 " Shaohua Li
2012-03-16 7:32 ` [patch v2 5/6] md: raid 1 " Shaohua Li
2012-03-16 7:32 ` [patch v2 6/6] md: raid 10 " Shaohua Li
2012-03-19 19:38 ` [patch v2 0/6] Add TRIM support for raid linear/0/1/10 Holger Kiehl
2012-03-20 1:27 ` Shaohua Li
2012-03-20 9:50 ` Holger Kiehl
2012-03-20 12:09 ` Shaohua Li
2012-03-21 2:08 ` Shaohua Li
2012-03-21 2:08 ` Shaohua Li
2012-03-21 2:24 ` Roberto Spadim
2012-03-21 2:29 ` Mathias Burén
2012-03-21 2:29 ` Mathias Burén
2012-03-21 2:29 ` Mathias Burén
2012-05-08 9:59 ` Patelczyk, Maciej
2012-05-09 2:27 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316073512.485027511@fusionio.com \
--to=shli@fusionio.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.