From: Christoph Hellwig <hch@infradead.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Shaohua Li <shli@kernel.org>, Vivek Goyal <vgoyal@redhat.com>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
neilb@suse.de, axboe@kernel.dk
Subject: Re: [patch v2 2/6] blk: dont allow discard request merge temporarily
Date: Thu, 22 Mar 2012 02:28:51 -0400 [thread overview]
Message-ID: <20120322062850.GA25288@infradead.org> (raw)
In-Reply-To: <yq1d385wf75.fsf@sermon.lab.mkp.net>
On Wed, Mar 21, 2012 at 10:18:54PM -0400, Martin K. Petersen wrote:
> >>>>> "Shaohua" == Shaohua Li <shli@kernel.org> writes:
>
> Shaohua> Enabling discard merge is required for device with slow discard
> Shaohua> (and very helpful for raid),
>
> Before RAID support there really wasn't much point. That's one of the
> reasons the current discard merge code has survived despite being
> completely broken.
I've actually send repeated bug reports about it beeing broken when
I enabled async discard in XFS which led to merges, and debugged it down
to beeing a problem with merges. But Jens didn't like my patch to mark
them nomerged, so we still couldn't commit the async discard support for
XFS which would have helped quite a bit with discard performance.
next prev parent reply other threads:[~2012-03-22 6:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 7:32 [patch v2 0/6] Add TRIM support for raid linear/0/1/10 Shaohua Li
2012-03-16 7:32 ` [patch v2 1/6] block: makes bio_split support bio without data Shaohua Li
2012-03-16 7:32 ` [patch v2 2/6] blk: dont allow discard request merge temporarily Shaohua Li
2012-03-20 16:21 ` Vivek Goyal
2012-03-21 1:22 ` Shaohua Li
2012-03-21 12:14 ` [patch 1/2]block: handle merged discard request Shaohua Li
2012-03-22 2:32 ` Martin K. Petersen
2012-03-22 2:39 ` Shaohua Li
2012-03-22 2:53 ` Martin K. Petersen
2012-06-20 8:57 ` Christoph Hellwig
2012-06-22 3:46 ` Martin K. Petersen
2012-08-03 2:10 ` Shaohua Li
2012-08-18 3:06 ` Mike Snitzer
2012-08-18 3:47 ` Martin K. Petersen
2012-08-20 13:57 ` Mike Snitzer
2012-08-20 13:58 ` Christoph Hellwig
2012-08-20 14:12 ` Mike Snitzer
2012-08-20 14:15 ` Christoph Hellwig
2012-03-22 2:18 ` [patch v2 2/6] blk: dont allow discard request merge temporarily Martin K. Petersen
2012-03-22 2:33 ` Shaohua Li
2012-03-22 6:28 ` Christoph Hellwig [this message]
2012-03-16 7:32 ` [patch v2 3/6] md: linear supports TRIM Shaohua Li
2012-03-16 7:32 ` [patch v2 4/6] md: raid 0 " Shaohua Li
2012-03-16 7:32 ` [patch v2 5/6] md: raid 1 " Shaohua Li
2012-03-16 7:32 ` [patch v2 6/6] md: raid 10 " Shaohua Li
2012-03-19 19:38 ` [patch v2 0/6] Add TRIM support for raid linear/0/1/10 Holger Kiehl
2012-03-20 1:27 ` Shaohua Li
2012-03-20 9:50 ` Holger Kiehl
2012-03-20 12:09 ` Shaohua Li
2012-03-21 2:08 ` Shaohua Li
2012-03-21 2:08 ` Shaohua Li
2012-03-21 2:24 ` Roberto Spadim
2012-03-21 2:29 ` Mathias Burén
2012-03-21 2:29 ` Mathias Burén
2012-03-21 2:29 ` Mathias Burén
2012-05-08 9:59 ` Patelczyk, Maciej
2012-05-09 2:27 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322062850.GA25288@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=shli@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.