All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Hong Xu <hong.xu@atmel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Add MICBIAS routing information for WM8904
Date: Fri, 16 Mar 2012 19:04:53 +0000	[thread overview]
Message-ID: <20120316190450.GE3158@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1331888098-28717-1-git-send-email-hong.xu@atmel.com>


[-- Attachment #1.1: Type: text/plain, Size: 722 bytes --]

On Fri, Mar 16, 2012 at 04:54:58PM +0800, Hong Xu wrote:

>  static const struct snd_soc_dapm_route adc_intercon[] = {
> +	{ "MICBIAS", NULL, "IN1L" },
> +	{ "MICBIAS", NULL, "IN1R" },
> +
> +	{ "Left Capture Mux", NULL, "MICBIAS" },
> +	{ "Right Capture Mux", NULL, "MICBIAS" },
> +	{ "Left Capture Inverting Mux", NULL, "MICBIAS" },
> +	{ "Right Capture Inverting Mux", NULL, "MICBIAS" },
> +

No, this is not something that the CODEC driver should do - the machine
driver should add connections for MICBIAS as this is something that's
determined by the board design.  The board could for example use some or
all of the inputs as simple line inputs (no bias needed), or it could
use an external MICBIAS for some reason.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2012-03-16 19:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16  8:54 [PATCH] ASoC: Add MICBIAS routing information for WM8904 Hong Xu
2012-03-16 19:04 ` Mark Brown [this message]
2012-03-19  1:15   ` Xu, Hong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120316190450.GE3158@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=hong.xu@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.