[PATCH] ASoC: Add MICBIAS routing information for WM8904

[PATCH] ASoC: Add MICBIAS routing information for WM8904

[Hong Xu]

Add MICBIAS routing entries for WM8904.

Tested on ATMEL's AT91SAM9N12-EK with a electret condenser
microphone connected to IN1L.

Signed-off-by: Hong Xu <hong.xu@atmel.com>
---
 sound/soc/codecs/wm8904.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index 285ef87..2158f30 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -1318,6 +1318,14 @@ static const struct snd_soc_dapm_route core_intercon[] = {
 };
 
 static const struct snd_soc_dapm_route adc_intercon[] = {
+	{ "MICBIAS", NULL, "IN1L" },
+	{ "MICBIAS", NULL, "IN1R" },
+
+	{ "Left Capture Mux", NULL, "MICBIAS" },
+	{ "Right Capture Mux", NULL, "MICBIAS" },
+	{ "Left Capture Inverting Mux", NULL, "MICBIAS" },
+	{ "Right Capture Inverting Mux", NULL, "MICBIAS" },
+
 	{ "Left Capture Mux", "IN1L", "IN1L" },
 	{ "Left Capture Mux", "IN2L", "IN2L" },
 	{ "Left Capture Mux", "IN3L", "IN3L" },
-- 
1.7.6

Re: [PATCH] ASoC: Add MICBIAS routing information for WM8904

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 722 bytes --]

On Fri, Mar 16, 2012 at 04:54:58PM +0800, Hong Xu wrote:

>  static const struct snd_soc_dapm_route adc_intercon[] = {
> +	{ "MICBIAS", NULL, "IN1L" },
> +	{ "MICBIAS", NULL, "IN1R" },
> +
> +	{ "Left Capture Mux", NULL, "MICBIAS" },
> +	{ "Right Capture Mux", NULL, "MICBIAS" },
> +	{ "Left Capture Inverting Mux", NULL, "MICBIAS" },
> +	{ "Right Capture Inverting Mux", NULL, "MICBIAS" },
> +

No, this is not something that the CODEC driver should do - the machine
driver should add connections for MICBIAS as this is something that's
determined by the board design.  The board could for example use some or
all of the inputs as simple line inputs (no bias needed), or it could
use an external MICBIAS for some reason.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: Add MICBIAS routing information for WM8904

[Xu, Hong]

Hi Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Saturday, March 17, 2012 3:05 AM
> To: Xu, Hong
> Cc: alsa-devel@alsa-project.org
> Subject: Re: [PATCH] ASoC: Add MICBIAS routing information for WM8904
> 
> On Fri, Mar 16, 2012 at 04:54:58PM +0800, Hong Xu wrote:
> 
> >  static const struct snd_soc_dapm_route adc_intercon[] = {
> > +	{ "MICBIAS", NULL, "IN1L" },
> > +	{ "MICBIAS", NULL, "IN1R" },
> > +
> > +	{ "Left Capture Mux", NULL, "MICBIAS" },
> > +	{ "Right Capture Mux", NULL, "MICBIAS" },
> > +	{ "Left Capture Inverting Mux", NULL, "MICBIAS" },
> > +	{ "Right Capture Inverting Mux", NULL, "MICBIAS" },
> > +
> 
> No, this is not something that the CODEC driver should do - the
machine
> driver should add connections for MICBIAS as this is something that's
> determined by the board design.  The board could for example use some
or
> all of the inputs as simple line inputs (no bias needed), or it could
> use an external MICBIAS for some reason.

OK, got it. Thanks.

BR,
Eric