From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Karol Lewandowski
<k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH 0/2] i2c: Don't assume bus nr 0 if none was specified
Date: Sat, 17 Mar 2012 10:50:56 +0000 [thread overview]
Message-ID: <20120317105056.BC9EE3E093F@localhost> (raw)
In-Reply-To: <4F6331AF.3010007-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On Fri, 16 Mar 2012 13:27:27 +0100, Karol Lewandowski <k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> On 16.03.2012 13:19, Karol Lewandowski wrote:
>
> > Hi,
> >
> > i2c controller drivers used to assume bus number 0 when none (-1) was specified.
> >
> > This worked on non-device tree systems, where one could explicitly specify
> > bus number via platform data. On DT-enabled systems bus number is always -1.
> >
> > Some drivers assume bus number 0 when -1 is specified. This patchset kills
> > this logic and switches to dynamic bus allocation (default when -1 is provided[1]).
>
>
> [ I must have lost actual problem description while rewording
> message itself... ]
>
> Problem arises when multiple drivers (or multiple instances
> of one driver) try to assume the same fixed bus number (0).
>
> This causes simply causes i2c_add_numbered_bus() to fail.
> Leaving -1 works perfectly, as registration function switches
> to dynamic id registration.
Patch series looks good to me. You'll need acks from the affected users.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Karol Lewandowski <k.lewandowsk@samsung.com>, w.sang@pengutronix.de
Cc: ben-linux@fluff.org, khali@linux-fr.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
hskinnemoen@gmail.com, dirk.brandewie@gmail.com,
bigeasy@linutronix.de, m.szyprowski@samsung.com,
kyungmin.park@samsung.com
Subject: Re: [PATCH 0/2] i2c: Don't assume bus nr 0 if none was specified
Date: Sat, 17 Mar 2012 10:50:56 +0000 [thread overview]
Message-ID: <20120317105056.BC9EE3E093F@localhost> (raw)
In-Reply-To: <4F6331AF.3010007@samsung.com>
On Fri, 16 Mar 2012 13:27:27 +0100, Karol Lewandowski <k.lewandowsk@samsung.com> wrote:
> On 16.03.2012 13:19, Karol Lewandowski wrote:
>
> > Hi,
> >
> > i2c controller drivers used to assume bus number 0 when none (-1) was specified.
> >
> > This worked on non-device tree systems, where one could explicitly specify
> > bus number via platform data. On DT-enabled systems bus number is always -1.
> >
> > Some drivers assume bus number 0 when -1 is specified. This patchset kills
> > this logic and switches to dynamic bus allocation (default when -1 is provided[1]).
>
>
> [ I must have lost actual problem description while rewording
> message itself... ]
>
> Problem arises when multiple drivers (or multiple instances
> of one driver) try to assume the same fixed bus number (0).
>
> This causes simply causes i2c_add_numbered_bus() to fail.
> Leaving -1 works perfectly, as registration function switches
> to dynamic id registration.
Patch series looks good to me. You'll need acks from the affected users.
g.
next prev parent reply other threads:[~2012-03-17 10:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 12:19 [PATCH 0/2] i2c: Don't assume bus nr 0 if none was specified Karol Lewandowski
[not found] ` <1331900343-6743-1-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-16 12:19 ` [PATCH 1/2] i2c-pxa: Drop leftover comment Karol Lewandowski
2012-03-16 12:19 ` Karol Lewandowski
2012-03-16 12:19 ` [PATCH 2/2] i2c: Dynamically assign adapter id if it wasn't explictly specified Karol Lewandowski
2012-03-16 12:19 ` Karol Lewandowski
2012-03-22 15:28 ` Karol Lewandowski
[not found] ` <4F6B4532.7090806-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-22 16:11 ` Russell King - ARM Linux
2012-03-22 16:11 ` Russell King - ARM Linux
2012-03-22 17:03 ` Karol Lewandowski
2012-03-22 16:58 ` David Daney
2012-03-22 16:58 ` David Daney
[not found] ` <4F6B5A22.1090204-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2012-03-22 17:48 ` Karol Lewandowski
2012-03-22 17:48 ` Karol Lewandowski
[not found] ` <4F6B65D0.1030506-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-22 18:07 ` David Daney
2012-03-22 18:07 ` David Daney
2012-03-22 21:47 ` Wolfram Sang
2012-03-22 21:47 ` Wolfram Sang
[not found] ` <20120322214714.GA24684-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-03-26 9:14 ` Karol Lewandowski
2012-03-26 9:14 ` Karol Lewandowski
2012-03-16 12:27 ` [PATCH 0/2] i2c: Don't assume bus nr 0 if none was specified Karol Lewandowski
2012-03-16 12:27 ` Karol Lewandowski
[not found] ` <4F6331AF.3010007-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-17 10:50 ` Grant Likely [this message]
2012-03-17 10:50 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120317105056.BC9EE3E093F@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.