All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-nfs@vger.kernel.org>
Cc: <Trond.Myklebust@netapp.com>
Subject: _nfs_display_fhandle_hash: undefined reference to `crc32_le'
Date: Sun, 18 Mar 2012 14:13:05 -0400	[thread overview]
Message-ID: <20120318181304.GA2095@windriver.com> (raw)

This started showing up in linux-next last week:

  LD      .tmp_vmlinux1
fs/built-in.o: In function `_nfs_display_fhandle_hash':
/scratch/kisskb/src/fs/nfs/inode.c:1063: undefined reference to `crc32_le'
make[1]: *** [.tmp_vmlinux1] Error 1

Target is an mpc8xx board:

http://kisskb.ellerman.id.au/kisskb/target/2679/

I tried to run an automated bisect on it, but there appears to
be build failures in the bisection range, in addition to the
above link error (i.e. points I'd use "skip" on if I wasn't
using "git bisect run ...")

# good: [b030fb0bb113316cc6f56779388b8572ab0699da] SUNRPC: use proper network namespace in rpcbind RPCBPROC_GETADDR procedure
git bisect good b030fb0bb113316cc6f56779388b8572ab0699da
# bad: [5247fab5c82779174d50590e0200bf532248a8a1] SUNRPC: pass network namespace to service registering routines
git bisect bad 5247fab5c82779174d50590e0200bf532248a8a1

Even without the concrete trigger commit, a suggested possible
fix (tested locally) is below.

Paul.
---

 From 21b77ae0373725bd2c60eca065e77c4d2f0fdbfa Mon Sep 17 00:00:00 2001
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Sun, 18 Mar 2012 14:07:42 -0400
Subject: [PATCH] nfs: select CRC32 for when NFS is enabled for crc32_le

To avoid the following link errors:

  LD      .tmp_vmlinux1
fs/built-in.o: In function `_nfs_display_fhandle_hash':
fs/nfs/inode.c:1063: undefined reference to `crc32_le'
make[1]: *** [.tmp_vmlinux1] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index 7bce64c..9acdfb0 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -3,6 +3,7 @@ config NFS_FS
 	depends on INET && FILE_LOCKING
 	select LOCKD
 	select SUNRPC
+	select CRC32
 	select NFS_ACL_SUPPORT if NFS_V3_ACL
 	help
 	  Choose Y here if you want to access files residing on other
-- 
1.7.9.1


             reply	other threads:[~2012-03-18 18:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-18 18:13 Paul Gortmaker [this message]
2012-03-19 15:35 ` _nfs_display_fhandle_hash: undefined reference to `crc32_le' Adamson, Dros
2012-03-19 16:29   ` Jim Rees
2012-03-19 18:20   ` Myklebust, Trond
2012-03-19 18:48     ` Adamson, Dros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120318181304.GA2095@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.