From: Jim Rees <rees@umich.edu>
To: "Adamson, Dros" <Weston.Adamson@netapp.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
"Myklebust, Trond" <Trond.Myklebust@netapp.com>,
linux-nfs list <linux-nfs@vger.kernel.org>
Subject: Re: _nfs_display_fhandle_hash: undefined reference to `crc32_le'
Date: Mon, 19 Mar 2012 12:29:43 -0400 [thread overview]
Message-ID: <20120319162943.GA19160@umich.edu> (raw)
In-Reply-To: <194578ED-EA46-479D-A61A-08D1A92FF80C@netapp.com>
Adamson, Dros wrote:
Oops! The fix is ok, in that it will work, but I'm not sure we want to
pull in that type of dependency for a debug message.
crc32 isn't that much of a burden. I'm surprised it's even optional. Your
proposed fix gives a useless hash and will result in confusion. I say pull
in crc32.
next prev parent reply other threads:[~2012-03-19 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-18 18:13 _nfs_display_fhandle_hash: undefined reference to `crc32_le' Paul Gortmaker
2012-03-19 15:35 ` Adamson, Dros
2012-03-19 16:29 ` Jim Rees [this message]
2012-03-19 18:20 ` Myklebust, Trond
2012-03-19 18:48 ` Adamson, Dros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319162943.GA19160@umich.edu \
--to=rees@umich.edu \
--cc=Trond.Myklebust@netapp.com \
--cc=Weston.Adamson@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.