From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Marc Reilly <marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
Cc: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
oskar-fYPSZ7JpQqsAvxtiuMwx3w@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 2/4] mfd: mc13xxx-core: use regmap for register access
Date: Mon, 19 Mar 2012 12:00:15 +0000 [thread overview]
Message-ID: <20120319120015.GA5705@sirena.org.uk> (raw)
In-Reply-To: <1332129838-7080-3-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
On Mon, Mar 19, 2012 at 03:03:56PM +1100, Marc Reilly wrote:
> This change converts the mc13xxx core to use regmap rather than direct
> spi r/w.
> The spidev member of mc13xxx struct becomes redundant and is removed.
> Extra debugging aids are added to mc13xxx_reg_rmw.
> Mutex init is moved to before regmap init.
Reviewed-by: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
though like I said it'd be good to get the rmw trace into regmap - if
it's useful to you here similar trace is probably going to be useful to
other users.
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/4] mfd: mc13xxx-core: use regmap for register access
Date: Mon, 19 Mar 2012 12:00:15 +0000 [thread overview]
Message-ID: <20120319120015.GA5705@sirena.org.uk> (raw)
In-Reply-To: <1332129838-7080-3-git-send-email-marc@cpdesign.com.au>
On Mon, Mar 19, 2012 at 03:03:56PM +1100, Marc Reilly wrote:
> This change converts the mc13xxx core to use regmap rather than direct
> spi r/w.
> The spidev member of mc13xxx struct becomes redundant and is removed.
> Extra debugging aids are added to mc13xxx_reg_rmw.
> Mutex init is moved to before regmap init.
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
though like I said it'd be good to get the rmw trace into regmap - if
it's useful to you here similar trace is probably going to be useful to
other users.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marc Reilly <marc@cpdesign.com.au>
Cc: sameo@linux.intel.com, linux-arm-kernel@lists.infradead.org,
spi-devel-general@lists.sourceforge.net,
linux-i2c@vger.kernel.org, u.kleine-koenig@pengutronix.de,
oskar@scara.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] mfd: mc13xxx-core: use regmap for register access
Date: Mon, 19 Mar 2012 12:00:15 +0000 [thread overview]
Message-ID: <20120319120015.GA5705@sirena.org.uk> (raw)
In-Reply-To: <1332129838-7080-3-git-send-email-marc@cpdesign.com.au>
On Mon, Mar 19, 2012 at 03:03:56PM +1100, Marc Reilly wrote:
> This change converts the mc13xxx core to use regmap rather than direct
> spi r/w.
> The spidev member of mc13xxx struct becomes redundant and is removed.
> Extra debugging aids are added to mc13xxx_reg_rmw.
> Mutex init is moved to before regmap init.
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
though like I said it'd be good to get the rmw trace into regmap - if
it's useful to you here similar trace is probably going to be useful to
other users.
next prev parent reply other threads:[~2012-03-19 12:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 4:03 mc13xxx: add I2C support (now with regmap), V4 Marc Reilly
2012-03-19 4:03 ` Marc Reilly
2012-03-19 4:03 ` Marc Reilly
[not found] ` <1332129838-7080-1-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-03-19 4:03 ` [PATCH v4 1/4] mfd: mc13xxx-core: Prepare for separate spi and i2c backends Marc Reilly
2012-03-19 4:03 ` Marc Reilly
2012-03-19 4:03 ` Marc Reilly
2012-03-19 4:03 ` [PATCH v4 2/4] mfd: mc13xxx-core: use regmap for register access Marc Reilly
2012-03-19 4:03 ` Marc Reilly
2012-03-19 4:03 ` Marc Reilly
[not found] ` <1332129838-7080-3-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-03-19 12:00 ` Mark Brown [this message]
2012-03-19 12:00 ` Mark Brown
2012-03-19 12:00 ` Mark Brown
2012-03-19 4:03 ` [PATCH v4 3/4] mfd: mc13xxx-core: Move spi specific code into separate module Marc Reilly
2012-03-19 4:03 ` Marc Reilly
2012-03-19 4:03 ` Marc Reilly
2012-03-19 4:03 ` [PATCH v4 4/4] mfd: mc13xxx: Add i2c driver Marc Reilly
2012-03-19 4:03 ` Marc Reilly
2012-03-19 4:03 ` Marc Reilly
[not found] ` <1332129838-7080-5-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-03-27 8:24 ` Oskar Schirmer
2012-03-27 8:24 ` Oskar Schirmer
2012-03-27 8:24 ` Oskar Schirmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319120015.GA5705@sirena.org.uk \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org \
--cc=oskar-fYPSZ7JpQqsAvxtiuMwx3w@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.