From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Linus Walleij
<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Subject: Re: [PATCH] gpio: tegra: tegra_gpio_config shouldn't be __init
Date: Mon, 19 Mar 2012 21:49:55 +0000 [thread overview]
Message-ID: <20120319214955.378CB3E0A04@localhost> (raw)
In-Reply-To: <1332178560-15658-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Mon, 19 Mar 2012 11:36:00 -0600, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
> This function is called from non-__init context, just like
> tegra_gpio_enable()/disable(). Remove the __init annotation to avoid
> section mismatch warnings during compile.
>
> Signed-off-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-tegra.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 636be99..32de670 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -461,7 +461,7 @@ static int __init tegra_gpio_init(void)
> }
> postcore_initcall(tegra_gpio_init);
>
> -void __init tegra_gpio_config(struct tegra_gpio_table *table, int num)
> +void tegra_gpio_config(struct tegra_gpio_table *table, int num)
> {
> int i;
>
> --
> 1.7.0.4
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: tegra: tegra_gpio_config shouldn't be __init
Date: Mon, 19 Mar 2012 21:49:55 +0000 [thread overview]
Message-ID: <20120319214955.378CB3E0A04@localhost> (raw)
In-Reply-To: <1332178560-15658-1-git-send-email-swarren@wwwdotorg.org>
On Mon, 19 Mar 2012 11:36:00 -0600, Stephen Warren <swarren@wwwdotorg.org> wrote:
> This function is called from non-__init context, just like
> tegra_gpio_enable()/disable(). Remove the __init annotation to avoid
> section mismatch warnings during compile.
>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-tegra.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 636be99..32de670 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -461,7 +461,7 @@ static int __init tegra_gpio_init(void)
> }
> postcore_initcall(tegra_gpio_init);
>
> -void __init tegra_gpio_config(struct tegra_gpio_table *table, int num)
> +void tegra_gpio_config(struct tegra_gpio_table *table, int num)
> {
> int i;
>
> --
> 1.7.0.4
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
next prev parent reply other threads:[~2012-03-19 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 17:36 [PATCH] gpio: tegra: tegra_gpio_config shouldn't be __init Stephen Warren
2012-03-19 17:36 ` Stephen Warren
[not found] ` <1332178560-15658-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-19 21:49 ` Grant Likely [this message]
2012-03-19 21:49 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319214955.378CB3E0A04@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.