From: Tejun Heo <tj@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Patch workqueue: create new slab cache instead of hacking
Date: Wed, 21 Mar 2012 09:09:10 -0700 [thread overview]
Message-ID: <20120321160910.GB4246@google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203210910450.20482@router.home>
On Wed, Mar 21, 2012 at 09:12:04AM -0500, Christoph Lameter wrote:
> How about this instead?
>
> Subject: workqueues: Use new kmem cache to get aligned memory for workqueues
>
> The workqueue logic currently improvises by doing a kmalloc allocation and
> then aligning the object. Create a slab cache for that purpose with the
> proper alignment instead.
>
> Cleans up the code and makes things much simpler. No need anymore to carry
> an additional pointer to the beginning of the kmalloc object.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>
I don't know. At this point, this is only for singlethread and
unbound workqueues and we don't have too many of them left at this
point. I'd like to avoid creating a slab cache for this. How about
just leaving it be? If we develop other use cases for larger
alignments, let's worry about implementing something common then.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Patch workqueue: create new slab cache instead of hacking
Date: Wed, 21 Mar 2012 09:09:10 -0700 [thread overview]
Message-ID: <20120321160910.GB4246@google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203210910450.20482@router.home>
On Wed, Mar 21, 2012 at 09:12:04AM -0500, Christoph Lameter wrote:
> How about this instead?
>
> Subject: workqueues: Use new kmem cache to get aligned memory for workqueues
>
> The workqueue logic currently improvises by doing a kmalloc allocation and
> then aligning the object. Create a slab cache for that purpose with the
> proper alignment instead.
>
> Cleans up the code and makes things much simpler. No need anymore to carry
> an additional pointer to the beginning of the kmalloc object.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>
I don't know. At this point, this is only for singlethread and
unbound workqueues and we don't have too many of them left at this
point. I'd like to avoid creating a slab cache for this. How about
just leaving it be? If we develop other use cases for larger
alignments, let's worry about implementing something common then.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-03-21 16:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 10:21 [RFC PATCH 0/6] add kmalloc_align() Lai Jiangshan
2012-03-20 10:21 ` Lai Jiangshan
2012-03-20 10:21 ` [RFC PATCH 1/6] kenrel.h: add ALIGN_OF_LAST_BIT() Lai Jiangshan
2012-03-20 10:21 ` Lai Jiangshan
2012-03-20 11:32 ` Michal Nazarewicz
2012-03-20 11:32 ` Michal Nazarewicz
2012-03-20 14:03 ` Alexey Dobriyan
2012-03-20 14:03 ` Alexey Dobriyan
2012-03-20 14:08 ` Christoph Lameter
2012-03-20 14:20 ` Peter Seebach
2012-03-20 14:20 ` Peter Seebach
2012-03-20 10:21 ` [RFC PATCH 2/6] slub: add kmalloc_align() Lai Jiangshan
2012-03-20 10:21 ` Lai Jiangshan
2012-03-20 14:14 ` Christoph Lameter
2012-03-20 14:14 ` Christoph Lameter
2012-03-20 14:21 ` Christoph Lameter
2012-03-20 14:21 ` Christoph Lameter
2012-03-20 10:21 ` [RFC PATCH 3/6] slab: " Lai Jiangshan
2012-03-20 10:21 ` Lai Jiangshan
2012-03-20 10:21 ` [RFC PATCH 4/6] slob: don't couple the header size with the alignment Lai Jiangshan
2012-03-20 10:21 ` Lai Jiangshan
2012-03-20 10:21 ` [RFC PATCH 5/6] slob: add kmalloc_align() Lai Jiangshan
2012-03-20 10:21 ` Lai Jiangshan
2012-03-20 10:21 ` [RFC PATCH 6/6] workqueue: use kmalloc_align() instead of hacking Lai Jiangshan
2012-03-20 10:21 ` Lai Jiangshan
2012-03-20 15:15 ` Christoph Lameter
2012-03-20 15:15 ` Christoph Lameter
2012-03-20 15:46 ` Tejun Heo
2012-03-20 15:46 ` Tejun Heo
2012-03-21 3:02 ` Lai Jiangshan
2012-03-21 3:02 ` Lai Jiangshan
2012-03-21 5:14 ` Tejun Heo
2012-03-21 5:14 ` Tejun Heo
2012-03-21 14:12 ` Patch workqueue: create new slab cache " Christoph Lameter
2012-03-21 14:12 ` Christoph Lameter
2012-03-21 14:49 ` Eric Dumazet
2012-03-21 14:49 ` Eric Dumazet
2012-03-21 15:03 ` Christoph Lameter
2012-03-21 15:03 ` Christoph Lameter
2012-03-21 16:04 ` Eric Dumazet
2012-03-21 16:04 ` Eric Dumazet
2012-03-21 17:54 ` Christoph Lameter
2012-03-21 17:54 ` Christoph Lameter
2012-03-21 18:05 ` Eric Dumazet
2012-03-21 18:05 ` Eric Dumazet
2012-03-21 18:20 ` Christoph Lameter
2012-03-21 18:20 ` Christoph Lameter
2012-03-21 16:09 ` Tejun Heo [this message]
2012-03-21 16:09 ` Tejun Heo
2012-03-21 17:56 ` Christoph Lameter
2012-03-21 17:56 ` Christoph Lameter
2012-03-21 13:45 ` [RFC PATCH 6/6] workqueue: use kmalloc_align() " Christoph Lameter
2012-03-21 13:45 ` Christoph Lameter
2012-03-26 2:00 ` Lai Jiangshan
2012-03-26 2:00 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321160910.GB4246@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.