From: Matt Wilson <msw@amazon.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
"Keir (Xen.org)" <keir@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1 of 3 v2] PV-GRUB: Check for errors when applying patches to GRUB
Date: Wed, 21 Mar 2012 09:17:52 -0700 [thread overview]
Message-ID: <20120321161751.GC2168@US-SEA-R8XVZTX> (raw)
In-Reply-To: <20329.47902.521208.252208@mariner.uk.xensource.com>
On Wed, Mar 21, 2012 at 04:27:26AM -0700, Ian Jackson wrote:
>
> This looks correct but wouldn't it be better done with a "set -e" at
> the top of the shell command ?
Sure, that works too. And it's the more common style for other
Makefiles. Would you like me to repost with this change?
Matt
next prev parent reply other threads:[~2012-03-21 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 18:47 [PATCH 0 of 3 v2] PV-GRUB: add support for ext4 and btrfs Matt Wilson
2012-03-20 18:47 ` [PATCH 1 of 3 v2] PV-GRUB: Check for errors when applying patches to GRUB Matt Wilson
2012-03-21 10:24 ` Ian Campbell
2012-03-21 11:27 ` Ian Jackson
2012-03-21 16:17 ` Matt Wilson [this message]
2012-03-21 16:25 ` Ian Jackson
2012-03-20 18:47 ` [PATCH 2 of 3 v2] PV-GRUB: add support for ext4 Matt Wilson
2012-03-21 10:28 ` Ian Campbell
2012-03-20 18:47 ` [PATCH 3 of 3 v2] PV-GRUB: add support for btrfs Matt Wilson
2012-03-21 10:29 ` Ian Campbell
2012-03-27 14:02 ` [PATCH 0 of 3 v2] PV-GRUB: add support for ext4 and btrfs Ian Jackson
[not found] ` <20120325170728.GP4316@type.famille.thibault.fr>
2012-04-03 18:48 ` Matt Wilson
2012-04-04 10:06 ` Ian Jackson
2012-04-04 10:20 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321161751.GC2168@US-SEA-R8XVZTX \
--to=msw@amazon.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.