From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-trivial@nongnu.org, Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device
Date: Wed, 21 Mar 2012 20:28:11 +0200 [thread overview]
Message-ID: <20120321182810.GA25289@redhat.com> (raw)
In-Reply-To: <4F6A02D1.9060404@codemonkey.ws>
On Wed, Mar 21, 2012 at 11:33:21AM -0500, Anthony Liguori wrote:
> On 03/21/2012 11:26 AM, Anthony Liguori wrote:
> >On 03/21/2012 11:11 AM, Michael S. Tsirkin wrote:
> >>Frankly I don't see value in making it visible to the user,
> >>at all. We are just triggering windows reactivations
> >>without any user benefit. Why not return a fixed value there
> >>to avoid that?
> >
> >I don't see a problem making it fixed for 1.1, but for 1.0 and older, we should
> >expose what we were supposed to expose.
> >
> >We need to fix the bug first, then we can change the behavior.
>
> In some cases, like USB, we really do want to expose a version,
why, exactly?
> but
> we should probably only expose the major version, for instance, QEMU
> 1.x or 2.x. This would only be exposed by the appropriate machine
> types.
>
> Regards,
>
> Anthony Liguori
>
> >
> >Regards,
> >
> >Anthony Liguori
> >
> >>
> >>>>>>
> >>>>>>
> >
> >
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device
Date: Wed, 21 Mar 2012 20:28:11 +0200 [thread overview]
Message-ID: <20120321182810.GA25289@redhat.com> (raw)
In-Reply-To: <4F6A02D1.9060404@codemonkey.ws>
On Wed, Mar 21, 2012 at 11:33:21AM -0500, Anthony Liguori wrote:
> On 03/21/2012 11:26 AM, Anthony Liguori wrote:
> >On 03/21/2012 11:11 AM, Michael S. Tsirkin wrote:
> >>Frankly I don't see value in making it visible to the user,
> >>at all. We are just triggering windows reactivations
> >>without any user benefit. Why not return a fixed value there
> >>to avoid that?
> >
> >I don't see a problem making it fixed for 1.1, but for 1.0 and older, we should
> >expose what we were supposed to expose.
> >
> >We need to fix the bug first, then we can change the behavior.
>
> In some cases, like USB, we really do want to expose a version,
why, exactly?
> but
> we should probably only expose the major version, for instance, QEMU
> 1.x or 2.x. This would only be exposed by the appropriate machine
> types.
>
> Regards,
>
> Anthony Liguori
>
> >
> >Regards,
> >
> >Anthony Liguori
> >
> >>
> >>>>>>
> >>>>>>
> >
> >
next prev parent reply other threads:[~2012-03-21 18:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 4:59 [Qemu-trivial] [PATCH] Remove PCI class code from virtio balloon device David Gibson
2012-03-19 4:59 ` [Qemu-devel] " David Gibson
2012-03-19 11:33 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-19 11:33 ` Stefan Hajnoczi
2012-03-20 0:42 ` [Qemu-trivial] " David Gibson
2012-03-20 0:42 ` David Gibson
2012-03-20 9:54 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-20 9:54 ` Stefan Hajnoczi
2012-03-20 10:19 ` [Qemu-trivial] " David Gibson
2012-03-20 10:19 ` David Gibson
2012-03-21 11:26 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-21 11:26 ` Stefan Hajnoczi
2012-03-21 11:28 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-21 11:28 ` Stefan Hajnoczi
2012-03-21 13:24 ` [Qemu-trivial] " David Gibson
2012-03-21 13:24 ` David Gibson
2012-03-21 13:08 ` [Qemu-trivial] " Michael S. Tsirkin
2012-03-21 13:08 ` Michael S. Tsirkin
2012-03-21 14:42 ` [Qemu-trivial] " Anthony Liguori
2012-03-21 14:42 ` Anthony Liguori
2012-03-21 15:10 ` [Qemu-trivial] " Michael S. Tsirkin
2012-03-21 15:10 ` Michael S. Tsirkin
2012-03-21 15:14 ` [Qemu-trivial] " Anthony Liguori
2012-03-21 15:14 ` Anthony Liguori
2012-03-21 16:11 ` [Qemu-trivial] " Michael S. Tsirkin
2012-03-21 16:11 ` Michael S. Tsirkin
2012-03-21 16:26 ` [Qemu-trivial] " Anthony Liguori
2012-03-21 16:26 ` Anthony Liguori
2012-03-21 16:33 ` [Qemu-trivial] " Anthony Liguori
2012-03-21 16:33 ` Anthony Liguori
2012-03-21 18:28 ` Michael S. Tsirkin [this message]
2012-03-21 18:28 ` Michael S. Tsirkin
2012-03-21 18:11 ` [Qemu-trivial] " Michael S. Tsirkin
2012-03-21 18:11 ` Michael S. Tsirkin
2012-03-20 10:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321182810.GA25289@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.