From: Paul Mundt <lethal@linux-sh.org>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-fbdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kyrofb: fix on x86_64
Date: Thu, 22 Mar 2012 00:01:05 +0000 [thread overview]
Message-ID: <20120322000104.GB26543@linux-sh.org> (raw)
In-Reply-To: <201203212336.55396.linux@rainbow-software.org>
On Wed, Mar 21, 2012 at 11:36:50PM +0100, Ondrej Zary wrote:
> kyrofb is completely broken on x86_64 because the registers are defined as
> unsigned long. Change them to u32 to make the driver work.
> Tested with Hercules 3D Prophet 4000XT.
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
>
Looks fine to me.
Acked-by: Paul Mundt <lethal@linux-sh.org>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-fbdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kyrofb: fix on x86_64
Date: Thu, 22 Mar 2012 09:01:05 +0900 [thread overview]
Message-ID: <20120322000104.GB26543@linux-sh.org> (raw)
In-Reply-To: <201203212336.55396.linux@rainbow-software.org>
On Wed, Mar 21, 2012 at 11:36:50PM +0100, Ondrej Zary wrote:
> kyrofb is completely broken on x86_64 because the registers are defined as
> unsigned long. Change them to u32 to make the driver work.
> Tested with Hercules 3D Prophet 4000XT.
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
>
Looks fine to me.
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2012-03-22 0:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 22:36 [PATCH] kyrofb: fix on x86_64 Ondrej Zary
2012-03-21 22:36 ` Ondrej Zary
2012-03-22 0:01 ` Paul Mundt [this message]
2012-03-22 0:01 ` Paul Mundt
2012-04-07 11:38 ` Ondrej Zary
2012-04-07 11:38 ` Ondrej Zary
2012-04-07 11:48 ` Florian Tobias Schandinat
2012-04-12 2:18 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322000104.GB26543@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=FlorianSchandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.