From: Tony Lindgren <tony@atomide.com>
To: mathieu.poirier@linaro.org
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH 4/9] ARM: omap2+: fix building without i2c
Date: Fri, 23 Mar 2012 10:22:17 -0700 [thread overview]
Message-ID: <20120323172216.GB9859@atomide.com> (raw)
In-Reply-To: <1332522836-29517-5-git-send-email-mathieu.poirier@linaro.org>
* mathieu.poirier@linaro.org <mathieu.poirier@linaro.org> [120323 10:16]:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A trivial typo causes build breakage when I2C is disabled
> and omap_i2c_reset is set to NULL on OMAP:
>
> omap_hwmod_44xx_data.c:2287:11: error: lvalue required as unary '&' operand
>
> Removing the '&' character solves this.
We are now building in the omap_i2c_reset always, so this
should be revalidated. We currently don't have NULL version
of omap_i2c_reset any longer, so those '&' for functions are
mostly cosmetic right now.
Anyways, at least the commit message should be changed to
be current.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] ARM: omap2+: fix building without i2c
Date: Fri, 23 Mar 2012 10:22:17 -0700 [thread overview]
Message-ID: <20120323172216.GB9859@atomide.com> (raw)
In-Reply-To: <1332522836-29517-5-git-send-email-mathieu.poirier@linaro.org>
* mathieu.poirier at linaro.org <mathieu.poirier@linaro.org> [120323 10:16]:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A trivial typo causes build breakage when I2C is disabled
> and omap_i2c_reset is set to NULL on OMAP:
>
> omap_hwmod_44xx_data.c:2287:11: error: lvalue required as unary '&' operand
>
> Removing the '&' character solves this.
We are now building in the omap_i2c_reset always, so this
should be revalidated. We currently don't have NULL version
of omap_i2c_reset any longer, so those '&' for functions are
mostly cosmetic right now.
Anyways, at least the commit message should be changed to
be current.
Regards,
Tony
next prev parent reply other threads:[~2012-03-23 17:22 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 17:13 [PATCH 0/9] omap randconfig fixes for v3.3 mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 17:13 ` [PATCH 1/9] arm/omap: enable building omap2 without omap2420/2430 mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 17:13 ` [PATCH 2/9] omap: fix visibility of omap2_mbox_iva_priv mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 18:30 ` Tony Lindgren
2012-03-23 18:30 ` Tony Lindgren
2012-03-23 17:13 ` [PATCH 3/9] ARM: omap2/n8x0: work around modular omap mmc mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 17:29 ` Tony Lindgren
2012-03-23 17:29 ` Tony Lindgren
2012-03-24 9:23 ` Russell King - ARM Linux
2012-03-24 9:23 ` Russell King - ARM Linux
2012-03-23 17:13 ` [PATCH 4/9] ARM: omap2+: fix building without i2c mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 17:22 ` Tony Lindgren [this message]
2012-03-23 17:22 ` Tony Lindgren
2012-03-23 17:13 ` [PATCH 5/9] tty/serial/omap: console can only be built-in mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 18:33 ` Tony Lindgren
2012-03-23 18:33 ` Tony Lindgren
2012-03-23 17:13 ` [PATCH 6/9] omap2: select twl4030 support on boards that need it mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 17:13 ` [PATCH 7/9] omap2plus: ensure that one of omap2/3/4 is selected mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 17:28 ` Tony Lindgren
2012-03-23 17:28 ` Tony Lindgren
2012-03-23 17:38 ` Arnd Bergmann
2012-03-23 17:38 ` Arnd Bergmann
2012-03-23 18:14 ` Tony Lindgren
2012-03-23 18:14 ` Tony Lindgren
2012-03-23 17:13 ` [PATCH 8/9] arm: OMAP depends on MMU mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 17:13 ` [PATCH 9/9] ARM: omap: select CPU_FREQ_TABLE where needed mathieu.poirier
2012-03-23 17:13 ` mathieu.poirier at linaro.org
2012-03-23 18:27 ` Tony Lindgren
2012-03-23 18:27 ` Tony Lindgren
2012-03-26 23:09 ` Kevin Hilman
2012-03-26 23:09 ` Kevin Hilman
2012-03-29 17:28 ` [PATCH 0/9] omap randconfig fixes for v3.3 Tony Lindgren
2012-03-29 17:28 ` Tony Lindgren
2012-05-07 19:07 ` Tony Lindgren
2012-05-07 19:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323172216.GB9859@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.