* [PATCH] regmap: Add 24 bits support
@ 2012-03-26 14:40 ` Alex Gershgorin
0 siblings, 0 replies; 6+ messages in thread
From: Alex Gershgorin @ 2012-03-26 14:40 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds support for PMIC who use regmap and 24 bit registers
For example MC13892, the patch was tested on i.MX35-PDK
Signed-off-by: Alex Gershgorin <alexg@meprolight.com>
---
drivers/base/regmap/internal.h | 1 +
drivers/base/regmap/regmap.c | 18 ++++++++++++++++++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index 1a02b75..3c5d204 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -122,5 +122,6 @@ int regcache_lookup_reg(struct regmap *map, unsigned int reg);
extern struct regcache_ops regcache_rbtree_ops;
extern struct regcache_ops regcache_lzo_ops;
+typedef struct { __u8 b[3]; } __be24;
#endif
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 6555803..499ee6a 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -114,6 +114,13 @@ static void regmap_format_16(void *buf, unsigned int val)
b[0] = cpu_to_be16(val);
}
+static void regmap_format_24(void *buf, unsigned int val)
+{
+ __be24 *b = buf;
+
+ b[0] = (__be24){ {(val >> 16) & 0xff, (val >> 8) & 0xff, val & 0xff } };
+}
+
static unsigned int regmap_parse_8(void *buf)
{
u8 *b = buf;
@@ -130,6 +137,13 @@ static unsigned int regmap_parse_16(void *buf)
return b[0];
}
+static unsigned int regmap_parse_24(void *buf)
+{
+ __be24 *b = buf;
+
+ return (b->b[0] << 16) | (b->b[1] << 8) | (b->b[2]);
+}
+
/**
* regmap_init(): Initialise register map
*
@@ -229,6 +243,10 @@ struct regmap *regmap_init(struct device *dev,
map->format.format_val = regmap_format_16;
map->format.parse_val = regmap_parse_16;
break;
+ case 24:
+ map->format.format_val = regmap_format_24;
+ map->format.parse_val = regmap_parse_24;
+ break;
}
if (!map->format.format_write &&
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] regmap: Add 24 bits support
@ 2012-03-26 14:40 ` Alex Gershgorin
0 siblings, 0 replies; 6+ messages in thread
From: Alex Gershgorin @ 2012-03-26 14:40 UTC (permalink / raw)
To: Mark Brown
Cc: linux-kernel, linux-arm-kernel, marc.reilly, s.hauer,
fabio.estevam, Alex Gershgorin
This patch adds support for PMIC who use regmap and 24 bit registers
For example MC13892, the patch was tested on i.MX35-PDK
Signed-off-by: Alex Gershgorin <alexg@meprolight.com>
---
drivers/base/regmap/internal.h | 1 +
drivers/base/regmap/regmap.c | 18 ++++++++++++++++++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index 1a02b75..3c5d204 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -122,5 +122,6 @@ int regcache_lookup_reg(struct regmap *map, unsigned int reg);
extern struct regcache_ops regcache_rbtree_ops;
extern struct regcache_ops regcache_lzo_ops;
+typedef struct { __u8 b[3]; } __be24;
#endif
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 6555803..499ee6a 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -114,6 +114,13 @@ static void regmap_format_16(void *buf, unsigned int val)
b[0] = cpu_to_be16(val);
}
+static void regmap_format_24(void *buf, unsigned int val)
+{
+ __be24 *b = buf;
+
+ b[0] = (__be24){ {(val >> 16) & 0xff, (val >> 8) & 0xff, val & 0xff } };
+}
+
static unsigned int regmap_parse_8(void *buf)
{
u8 *b = buf;
@@ -130,6 +137,13 @@ static unsigned int regmap_parse_16(void *buf)
return b[0];
}
+static unsigned int regmap_parse_24(void *buf)
+{
+ __be24 *b = buf;
+
+ return (b->b[0] << 16) | (b->b[1] << 8) | (b->b[2]);
+}
+
/**
* regmap_init(): Initialise register map
*
@@ -229,6 +243,10 @@ struct regmap *regmap_init(struct device *dev,
map->format.format_val = regmap_format_16;
map->format.parse_val = regmap_parse_16;
break;
+ case 24:
+ map->format.format_val = regmap_format_24;
+ map->format.parse_val = regmap_parse_24;
+ break;
}
if (!map->format.format_write &&
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] regmap: Add 24 bits support
2012-03-26 14:40 ` Alex Gershgorin
@ 2012-03-26 14:50 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-03-26 14:50 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Mar 26, 2012 at 04:40:08PM +0200, Alex Gershgorin wrote:
> This patch adds support for PMIC who use regmap and 24 bit registers
> For example MC13892, the patch was tested on i.MX35-PDK
A similar patch from Marc Reilly has already been applied. You don't
have his signoff here but then...
> +typedef struct { __u8 b[3]; } __be24;
...you're adding stuff like this to the regmap headers which *clearly*
isn't regmap specific so this looks like a separate development.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120326/29610d5f/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] regmap: Add 24 bits support
@ 2012-03-26 14:50 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-03-26 14:50 UTC (permalink / raw)
To: Alex Gershgorin
Cc: linux-kernel, linux-arm-kernel, marc.reilly, s.hauer,
fabio.estevam
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Mon, Mar 26, 2012 at 04:40:08PM +0200, Alex Gershgorin wrote:
> This patch adds support for PMIC who use regmap and 24 bit registers
> For example MC13892, the patch was tested on i.MX35-PDK
A similar patch from Marc Reilly has already been applied. You don't
have his signoff here but then...
> +typedef struct { __u8 b[3]; } __be24;
...you're adding stuff like this to the regmap headers which *clearly*
isn't regmap specific so this looks like a separate development.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] regmap: Add 24 bits support
2012-03-26 14:50 ` Mark Brown
@ 2012-03-26 17:30 ` Alex Gershgorin
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Gershgorin @ 2012-03-26 17:30 UTC (permalink / raw)
To: linux-arm-kernel
>Subject: Re: [PATCH] regmap: Add 24 bits support
On Mon, Mar 26, 2012 at 04:40:08PM +0200, Alex Gershgorin wrote:
> This patch adds support for PMIC who use regmap and 24 bit registers
> For example MC13892, the patch was tested on i.MX35-PDK
> >A similar patch from Marc Reilly has already been applied. You don't
> >have his signoff here but then...
Sorry Marc, I missed the patch
> +typedef struct { __u8 b[3]; } __be24;
> > ...you're adding stuff like this to the regmap headers which *clearly*
> > isn't regmap specific so this looks like a separate development.
You right,
I think it makes no sense to fix it,
why do we need two similar patches
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] regmap: Add 24 bits support
@ 2012-03-26 17:30 ` Alex Gershgorin
0 siblings, 0 replies; 6+ messages in thread
From: Alex Gershgorin @ 2012-03-26 17:30 UTC (permalink / raw)
To: Mark Brown
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, marc.reilly@gmail.com,
s.hauer@pengutronix.de, fabio.estevam@freescale.com
>Subject: Re: [PATCH] regmap: Add 24 bits support
On Mon, Mar 26, 2012 at 04:40:08PM +0200, Alex Gershgorin wrote:
> This patch adds support for PMIC who use regmap and 24 bit registers
> For example MC13892, the patch was tested on i.MX35-PDK
> >A similar patch from Marc Reilly has already been applied. You don't
> >have his signoff here but then...
Sorry Marc, I missed the patch
> +typedef struct { __u8 b[3]; } __be24;
> > ...you're adding stuff like this to the regmap headers which *clearly*
> > isn't regmap specific so this looks like a separate development.
You right,
I think it makes no sense to fix it,
why do we need two similar patches
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-26 17:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-26 14:40 [PATCH] regmap: Add 24 bits support Alex Gershgorin
2012-03-26 14:40 ` Alex Gershgorin
2012-03-26 14:50 ` Mark Brown
2012-03-26 14:50 ` Mark Brown
2012-03-26 17:30 ` Alex Gershgorin
2012-03-26 17:30 ` Alex Gershgorin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.