From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: "swarren@nvidia.com" <swarren@nvidia.com>,
"olof@lixom.net" <olof@lixom.net>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
spear-devel <spear-devel@list.st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
"sr@denx.de" <sr@denx.de>
Subject: Re: [PATCH V2 2/2] Input: spear-keyboard: add device tree bindings
Date: Tue, 27 Mar 2012 00:51:52 -0700 [thread overview]
Message-ID: <20120327075152.GA5433@core.coreip.homeip.net> (raw)
In-Reply-To: <4F716E4F.4050408@st.com>
On Tue, Mar 27, 2012 at 01:07:51PM +0530, Viresh Kumar wrote:
> On 3/27/2012 12:43 PM, Dmitry Torokhov wrote:
> > I think the opposite order woudl make more sense - if pdata is supplied
> > by the platform code then we should use it, otherwise try to see if
> > there is OF data available instead. This way one can easily override OF
> > data, if needed.
>
> Okay.
>
> Just for better understanding, why should we give more preference to pdata?
>
> I thought, a single image with pdata can be booted with or without DT
> support for keyboard. So, if we are booting without of DT for keyboard,
> then use pdata, otherwise use DT data.
My reasoning is that device tree is in firmware and it might be
desirable to override firmware in certain cases.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-03-27 7:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 5:38 [PATCH V2 1/2] Input: of_keymap: Introduce matrix_keypad_of_build_keymap() Viresh Kumar
2012-03-27 5:38 ` [PATCH V2 2/2] Input: spear-keyboard: add device tree bindings Viresh Kumar
2012-03-27 7:13 ` Dmitry Torokhov
2012-03-27 7:37 ` Viresh Kumar
2012-03-27 7:51 ` Dmitry Torokhov [this message]
2012-03-27 8:05 ` Viresh Kumar
2012-03-27 15:46 ` Stephen Warren
2012-03-27 15:45 ` [PATCH V2 1/2] Input: of_keymap: Introduce matrix_keypad_of_build_keymap() Stephen Warren
2012-03-28 4:55 ` Viresh Kumar
2012-03-28 21:28 ` Stephen Warren
2012-03-29 8:23 ` Viresh Kumar
[not found] ` <4aba6f2cd9f050f419660555bdb661915c1be9b1.1332826100.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-03-28 9:54 ` [PATCH V3 2/2] Input: spear-keyboard: add device tree bindings Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327075152.GA5433@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-input@vger.kernel.org \
--cc=olof@lixom.net \
--cc=spear-devel@list.st.com \
--cc=sr@denx.de \
--cc=swarren@nvidia.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.