From: Viresh Kumar <viresh.kumar@st.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
spear-devel <spear-devel@list.st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"sr@denx.de" <sr@denx.de>
Subject: Re: [PATCH V2 1/2] Input: of_keymap: Introduce matrix_keypad_of_build_keymap()
Date: Thu, 29 Mar 2012 13:53:53 +0530 [thread overview]
Message-ID: <4F741C19.4080703@st.com> (raw)
In-Reply-To: <4F738261.1060002@wwwdotorg.org>
On 3/29/2012 2:58 AM, Stephen Warren wrote:
> so the DT parsing can easily overflow this, and is driven by
> user-supplied data.
Got it. This check is must.
> I think you'll need to pass input_dev->keycodesize
you mean keycodemax here?
> into matrix_keypad_of_build_keymap() to achieve the overall
> range-checking.
Will do that.
> but also checking col against (1<<row_shift) would be
> needed to make sure the individual "fields" of the array index don't
> overflow too.
Ok. Please cross check V3 to verify, i got you comments correctly.
--
viresh
next prev parent reply other threads:[~2012-03-29 8:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 5:38 [PATCH V2 1/2] Input: of_keymap: Introduce matrix_keypad_of_build_keymap() Viresh Kumar
2012-03-27 5:38 ` [PATCH V2 2/2] Input: spear-keyboard: add device tree bindings Viresh Kumar
2012-03-27 7:13 ` Dmitry Torokhov
2012-03-27 7:37 ` Viresh Kumar
2012-03-27 7:51 ` Dmitry Torokhov
2012-03-27 8:05 ` Viresh Kumar
2012-03-27 15:46 ` Stephen Warren
2012-03-27 15:45 ` [PATCH V2 1/2] Input: of_keymap: Introduce matrix_keypad_of_build_keymap() Stephen Warren
2012-03-28 4:55 ` Viresh Kumar
2012-03-28 21:28 ` Stephen Warren
2012-03-29 8:23 ` Viresh Kumar [this message]
[not found] ` <4aba6f2cd9f050f419660555bdb661915c1be9b1.1332826100.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-03-28 9:54 ` [PATCH V3 2/2] Input: spear-keyboard: add device tree bindings Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F741C19.4080703@st.com \
--to=viresh.kumar@st.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=sr@denx.de \
--cc=swarren@wwwdotorg.org \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.