From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: [PATCH 3/3] padata: Fix cpu hotplug
Date: Wed, 28 Mar 2012 08:44:07 +0200 [thread overview]
Message-ID: <20120328064407.GG16191@secunet.com> (raw)
In-Reply-To: <20120328064157.GD16191@secunet.com>
We don't remove the cpu that went offline from our cpumasks
on cpu hotplug. This got lost somewhere along the line, so
restore it. This fixes a hang of the padata instance on cpu
hotplug.
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
kernel/padata.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index de3d0d9..89fe3d1 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -748,6 +748,9 @@ static int __padata_remove_cpu(struct padata_instance *pinst, int cpu)
return -ENOMEM;
padata_replace(pinst, pd);
+
+ cpumask_clear_cpu(cpu, pd->cpumask.cbcpu);
+ cpumask_clear_cpu(cpu, pd->cpumask.pcpu);
}
return 0;
--
1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: [PATCH 3/3] padata: Fix cpu hotplug
Date: Wed, 28 Mar 2012 08:44:07 +0200 [thread overview]
Message-ID: <20120328064407.GG16191@secunet.com> (raw)
In-Reply-To: <20120328064157.GD16191@secunet.com>
We don't remove the cpu that went offline from our cpumasks
on cpu hotplug. This got lost somewhere along the line, so
restore it. This fixes a hang of the padata instance on cpu
hotplug.
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
kernel/padata.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index de3d0d9..89fe3d1 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -748,6 +748,9 @@ static int __padata_remove_cpu(struct padata_instance *pinst, int cpu)
return -ENOMEM;
padata_replace(pinst, pd);
+
+ cpumask_clear_cpu(cpu, pd->cpumask.cbcpu);
+ cpumask_clear_cpu(cpu, pd->cpumask.pcpu);
}
return 0;
--
1.7.0.4
next prev parent reply other threads:[~2012-03-28 6:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 6:41 padata: Fixes for 3.4 Steffen Klassert
2012-03-28 6:41 ` Steffen Klassert
2012-03-28 6:42 ` [PATCH 1/3] padata: Add a reference to the api documentation Steffen Klassert
2012-03-28 6:42 ` Steffen Klassert
2012-03-28 6:43 ` [PATCH 2/3] padata: Use the online cpumask as the default Steffen Klassert
2012-03-28 6:43 ` Steffen Klassert
2012-03-28 6:44 ` Steffen Klassert [this message]
2012-03-28 6:44 ` [PATCH 3/3] padata: Fix cpu hotplug Steffen Klassert
2012-03-30 9:20 ` padata: Fixes for 3.4 Herbert Xu
2012-03-30 9:20 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328064407.GG16191@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.