From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: "Zeng@alsa-project.org" <Zeng@alsa-project.org>,
Xu Lionel-R63889 <R63889@freescale.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Zhaoming <zengzm.kernel@gmail.com>,
Dong Aisheng-B29396 <B29396@freescale.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ASoC: sgtl5000: fix power on/off of MIC bias
Date: Wed, 28 Mar 2012 15:36:50 +0100 [thread overview]
Message-ID: <20120328143649.GU3232@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120328141812.GB3254@S2101-09.ap.freescale.net>
[-- Attachment #1.1: Type: text/plain, Size: 567 bytes --]
On Wed, Mar 28, 2012 at 10:18:14PM +0800, Shawn Guo wrote:
> On Wed, Mar 28, 2012 at 09:52:15AM +0000, Dong Aisheng-B29396 wrote:
> > IIRC for line-in record, it may also need VAG_POWER up.
> > Then only enable VAG_POWER for mic_bias_event may not be sufficient.
> > Will verify it latter when I'm free.
> This patch only fixes MIC. I think you can submit another patch after
> you confirm LINE-IN has the same issue.
I think this is a sensible approach, two patches fixing two issues seems
reasonable (and I'd not expect line input to need the mic bias itself).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: sgtl5000: fix power on/off of MIC bias
Date: Wed, 28 Mar 2012 15:36:50 +0100 [thread overview]
Message-ID: <20120328143649.GU3232@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120328141812.GB3254@S2101-09.ap.freescale.net>
On Wed, Mar 28, 2012 at 10:18:14PM +0800, Shawn Guo wrote:
> On Wed, Mar 28, 2012 at 09:52:15AM +0000, Dong Aisheng-B29396 wrote:
> > IIRC for line-in record, it may also need VAG_POWER up.
> > Then only enable VAG_POWER for mic_bias_event may not be sufficient.
> > Will verify it latter when I'm free.
> This patch only fixes MIC. I think you can submit another patch after
> you confirm LINE-IN has the same issue.
I think this is a sensible approach, two patches fixing two issues seems
reasonable (and I'd not expect line input to need the mic bias itself).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120328/2c19f2ec/attachment.sig>
next prev parent reply other threads:[~2012-03-28 14:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 7:30 [PATCH] ASoC: sgtl5000: fix power on/off of MIC bias Shawn Guo
2012-03-28 7:30 ` Shawn Guo
2012-03-28 9:05 ` Zeng Zhaoming
2012-03-28 9:05 ` Zeng Zhaoming
2012-03-28 9:52 ` Dong Aisheng-B29396
2012-03-28 9:52 ` [alsa-devel] " Dong Aisheng-B29396
2012-03-28 10:11 ` Zeng Zhaoming
2012-03-28 10:11 ` Zeng Zhaoming
2012-03-28 11:17 ` Xu Lionel-R63889
2012-03-28 11:17 ` Xu Lionel-R63889
2012-03-28 14:18 ` Shawn Guo
2012-03-28 14:18 ` [alsa-devel] " Shawn Guo
2012-03-28 14:36 ` Mark Brown [this message]
2012-03-28 14:36 ` Mark Brown
2012-03-28 9:58 ` Dong Aisheng
2012-03-28 9:58 ` [alsa-devel] " Dong Aisheng
2012-03-29 5:56 ` Shawn Guo
2012-03-29 5:56 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328143649.GU3232@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=B29396@freescale.com \
--cc=R63889@freescale.com \
--cc=Zeng@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@linaro.org \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.