From: Andrea Arcangeli <aarcange@redhat.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Sasha Levin <levinsasha928@gmail.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: Re: [PATCH] pagemap: remove remaining unneeded spin_lock()
Date: Thu, 29 Mar 2012 22:26:28 +0200 [thread overview]
Message-ID: <20120329202628.GD20930@redhat.com> (raw)
In-Reply-To: <1333010379-31126-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On Thu, Mar 29, 2012 at 04:39:39AM -0400, Naoya Horiguchi wrote:
> commit: 025c5b2451e4 "thp: optimize away unnecessary page table locking"
> moves spin_lock() into pmd_trans_huge_lock() in order to avoid locking
> unless pmd is for thp. So this spin_lock() is a bug.
>
> Reported-by: Sasha Levin <levinsasha928@gmail.com>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Sasha Levin <levinsasha928@gmail.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: Re: [PATCH] pagemap: remove remaining unneeded spin_lock()
Date: Thu, 29 Mar 2012 22:26:28 +0200 [thread overview]
Message-ID: <20120329202628.GD20930@redhat.com> (raw)
In-Reply-To: <1333010379-31126-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On Thu, Mar 29, 2012 at 04:39:39AM -0400, Naoya Horiguchi wrote:
> commit: 025c5b2451e4 "thp: optimize away unnecessary page table locking"
> moves spin_lock() into pmd_trans_huge_lock() in order to avoid locking
> unless pmd is for thp. So this spin_lock() is a bug.
>
> Reported-by: Sasha Levin <levinsasha928@gmail.com>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
next prev parent reply other threads:[~2012-03-29 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 8:39 [PATCH] pagemap: remove remaining unneeded spin_lock() Naoya Horiguchi
2012-03-29 8:39 ` Naoya Horiguchi
2012-03-29 20:26 ` Andrea Arcangeli [this message]
2012-03-29 20:26 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329202628.GD20930@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.