From: Oleg Nesterov <oleg@redhat.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-mm <linux-mm@kvack.org>, Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/2] uprobes/core: counter to optimize probe hits.
Date: Fri, 30 Mar 2012 15:05:30 +0200 [thread overview]
Message-ID: <20120330130530.GA16319@redhat.com> (raw)
In-Reply-To: <20120321180826.22773.57531.sendpatchset@srdronam.in.ibm.com>
On 03/21, Srikar Dronamraju wrote:
>
> + * uprobe_munmap() decrements the count if
> + * - it sees a underlying breakpoint, (via is_swbp_at_addr)
> + * (Subsequent unregister_uprobe wouldnt find the breakpoint
> + * unless a uprobe_mmap kicks in, since the old vma would be
> + * dropped just after uprobe_munmap.)
> + *
> + * register_uprobe increments the count if:
> + * - it successfully adds a breakpoint.
> + *
> + * unregister_uprobe decrements the count if:
Cosmetic nit, register_uprobe/unregister_uprobe do not exist.
uprobe_register/unregister.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-mm <linux-mm@kvack.org>, Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/2] uprobes/core: counter to optimize probe hits.
Date: Fri, 30 Mar 2012 15:05:30 +0200 [thread overview]
Message-ID: <20120330130530.GA16319@redhat.com> (raw)
In-Reply-To: <20120321180826.22773.57531.sendpatchset@srdronam.in.ibm.com>
On 03/21, Srikar Dronamraju wrote:
>
> + * uprobe_munmap() decrements the count if
> + * - it sees a underlying breakpoint, (via is_swbp_at_addr)
> + * (Subsequent unregister_uprobe wouldnt find the breakpoint
> + * unless a uprobe_mmap kicks in, since the old vma would be
> + * dropped just after uprobe_munmap.)
> + *
> + * register_uprobe increments the count if:
> + * - it successfully adds a breakpoint.
> + *
> + * unregister_uprobe decrements the count if:
Cosmetic nit, register_uprobe/unregister_uprobe do not exist.
uprobe_register/unregister.
Oleg.
next prev parent reply other threads:[~2012-03-30 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 18:08 [PATCH 1/2] uprobes/core: slot allocation Srikar Dronamraju
2012-03-21 18:08 ` Srikar Dronamraju
2012-03-21 18:08 ` [PATCH 2/2] uprobes/core: counter to optimize probe hits Srikar Dronamraju
2012-03-21 18:08 ` Srikar Dronamraju
2012-03-23 12:45 ` Ingo Molnar
2012-03-23 12:45 ` Ingo Molnar
2012-03-30 13:05 ` Oleg Nesterov [this message]
2012-03-30 13:05 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120330130530.GA16319@redhat.com \
--to=oleg@redhat.com \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=andi@firstfloor.org \
--cc=hch@infradead.org \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.