From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: Fix comment for end of CONFIG_COMMON_CLK section
Date: Sun, 1 Apr 2012 15:29:20 +0100 [thread overview]
Message-ID: <20120401142918.GA8971@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120401130216.GA24211@n2100.arm.linux.org.uk>
On Sun, Apr 01, 2012 at 02:02:16PM +0100, Russell King - ARM Linux wrote:
> On Sun, Apr 01, 2012 at 12:32:39PM +0100, Mark Brown wrote:
> > There is no else block so the #endif is for the end of the section for
> > CONFIG_COMMON_CLK.
> Get rid of the comment entirely. For just a single level of ifdef it
> makes no sense.
That's actually my preference too, I was mostly just sticking with the
existing style. I'll send out a version doing that shortly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120401/b45390b8/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Mike Turquette <mturquette@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: Fix comment for end of CONFIG_COMMON_CLK section
Date: Sun, 1 Apr 2012 15:29:20 +0100 [thread overview]
Message-ID: <20120401142918.GA8971@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120401130216.GA24211@n2100.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
On Sun, Apr 01, 2012 at 02:02:16PM +0100, Russell King - ARM Linux wrote:
> On Sun, Apr 01, 2012 at 12:32:39PM +0100, Mark Brown wrote:
> > There is no else block so the #endif is for the end of the section for
> > CONFIG_COMMON_CLK.
> Get rid of the comment entirely. For just a single level of ifdef it
> makes no sense.
That's actually my preference too, I was mostly just sticking with the
existing style. I'll send out a version doing that shortly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-01 14:29 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 11:32 [PATCH 1/2] clk: Fix comment for end of CONFIG_COMMON_CLK section Mark Brown
2012-04-01 11:32 ` Mark Brown
2012-04-01 11:32 ` [PATCH 2/2] clkdev: Implement managed clk_get() Mark Brown
2012-04-01 11:32 ` Mark Brown
2012-04-01 15:26 ` Stephen Boyd
2012-04-01 15:26 ` Stephen Boyd
2012-04-01 15:34 ` Mark Brown
2012-04-01 15:34 ` Mark Brown
2012-04-02 16:48 ` Stephen Boyd
2012-04-02 16:48 ` Stephen Boyd
2012-04-02 16:52 ` Russell King - ARM Linux
2012-04-02 16:52 ` Russell King - ARM Linux
2012-04-02 17:04 ` Stephen Boyd
2012-04-02 17:04 ` Stephen Boyd
2012-04-02 17:08 ` Russell King - ARM Linux
2012-04-02 17:08 ` Russell King - ARM Linux
2012-04-02 17:16 ` Stephen Boyd
2012-04-02 17:16 ` Stephen Boyd
2012-04-02 17:21 ` Russell King - ARM Linux
2012-04-02 17:21 ` Russell King - ARM Linux
2012-04-02 17:34 ` Stephen Boyd
2012-04-02 17:34 ` Stephen Boyd
2012-04-02 18:02 ` Russell King - ARM Linux
2012-04-02 18:02 ` Russell King - ARM Linux
2012-04-02 17:16 ` Mark Brown
2012-04-02 17:16 ` Mark Brown
2012-04-02 17:30 ` Turquette, Mike
2012-04-02 17:30 ` Turquette, Mike
2012-04-02 17:04 ` Russell King - ARM Linux
2012-04-02 17:04 ` Russell King - ARM Linux
2012-04-02 17:34 ` Mark Brown
2012-04-02 17:34 ` Mark Brown
2012-04-02 18:05 ` Russell King - ARM Linux
2012-04-02 18:05 ` Russell King - ARM Linux
2012-04-01 13:02 ` [PATCH 1/2] clk: Fix comment for end of CONFIG_COMMON_CLK section Russell King - ARM Linux
2012-04-01 13:02 ` Russell King - ARM Linux
2012-04-01 14:29 ` Mark Brown [this message]
2012-04-01 14:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120401142918.GA8971@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.