Re: [PATCH] Add fc0011 tuner driver

["Michael Büsch" <m@bues.ch>]

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

On Mon, 02 Apr 2012 19:56:50 +0300
Antti Palosaari <crope@iki.fi> wrote:

> On 02.04.2012 19:14, Michael Büsch wrote:
> > This adds support for the Fitipower fc0011 DVB-t tuner.
> >
> > Signed-off-by: Michael Buesch<m@bues.ch>
> 
> Applied, thanks!
> http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental
> 
> I looked it through quickly, no big issues. Anyhow, when I ran 
> checkpatch.pl and it complains rather much. All Kernel developers must 
> use checkpatch.pl before sent patches and fix findings if possible, 
> errors must be fixed and warnings too if there is no good reason to 
> leave as it is.

Well, I _did_ run it on the patch.
There is no error. Only (IMO bogus) warnings. Most of them
are about the 80 char limit. Which isn't really a hard limit. And those lines
only exceed the 80 char limit by a few chars (one, two or such). Splitting
those line serves no readability purpose. In fact, it just worsens it.

> And one note about tuner driver, my AF9035 + FC0011 device founds only 1 
> mux of 4. Looks like some performance issues still to resolve.

I have no idea what this means.
So I have no remote idea of what could possibly be wrong here.
Is this a bug on af903x or the tuner driver?

-- 
Greetings, Michael.

PGP encryption is encouraged / 908D8B0E

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]