All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: "Michael Büsch" <m@bues.ch>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	linux-media <linux-media@vger.kernel.org>,
	Hans-Frieder Vogt <hfvogt@gmx.net>,
	Gianluca Gennari <gennarone@gmail.com>
Subject: Re: [PATCH] Add fc0011 tuner driver
Date: Tue, 03 Apr 2012 00:52:08 +0300	[thread overview]
Message-ID: <4F7A1F88.1060109@iki.fi> (raw)
In-Reply-To: <20120402195125.771b2c72@milhouse>

On 02.04.2012 20:51, Michael Büsch wrote:
>> Likely tuner driver, or demod driver. But as demod tuner initialization
>> tables are likely correct I suspect it is tuner issue at first hand. And
>> secondly my other hardware with TUA9001 performs very well, better than
>> old AF9015 sticks.
>
> Well the fc0011 tuner driver still works worse on this af9035 driver
> than on Hans' driver. I have absolutely no idea why this is the case.
> I'm almost certain that it is not a timing issue of some sort. I tried
> a zillion of delays and such.

And after taking sniffs and comparing those I found the reason. It is 
I2C adapter code. It writes one byte too much => as a FC0011 is 
auto-increment (as almost every I2C client) registers it means it writes 
next register too. Fixing that gives normal tuner sensitivity. I will 
try to make patch for that soon.

regards
Antti
-- 
http://palosaari.fi/

  reply	other threads:[~2012-04-02 21:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 16:14 [PATCH] Add fc0011 tuner driver Michael Büsch
2012-04-02 16:56 ` Antti Palosaari
2012-04-02 17:20   ` Michael Büsch
2012-04-02 17:40     ` Antti Palosaari
2012-04-02 17:51       ` Michael Büsch
2012-04-02 21:52         ` Antti Palosaari [this message]
2012-04-03  6:36           ` Michael Büsch
2012-05-07 19:02 ` Antti Palosaari
2012-05-07 21:00   ` Michael Büsch
2012-05-07 21:13     ` Rémi Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7A1F88.1060109@iki.fi \
    --to=crope@iki.fi \
    --cc=gennarone@gmail.com \
    --cc=hfvogt@gmx.net \
    --cc=linux-media@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.