From: Arnd Bergmann <arnd@arndb.de>
To: Roland Stigge <stigge@antcom.de>
Cc: a.zummo@towertech.it, srinivas.bakki@nxp.com,
linux-watchdog@vger.kernel.org, rtc-linux@googlegroups.com,
gregkh@linuxfoundation.org, w.sang@pengutronix.de,
kevin.wells@nxp.com, linux-kernel@vger.kernel.org, wim@iguana.be,
arm@kernel.org, linux-i2c@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
jonsmirl@gmail.com
Subject: Re: [PATCH v2 3/8] net: Add device tree support to LPC32xx
Date: Mon, 2 Apr 2012 19:37:54 +0000 [thread overview]
Message-ID: <201204021937.54567.arnd@arndb.de> (raw)
In-Reply-To: <1333391587-26290-4-git-send-email-stigge@antcom.de>
On Monday 02 April 2012, Roland Stigge wrote:
>
> + if (pdev->dev.of_node && of_get_property(pdev->dev.of_node,
> + "use-iram", NULL))
> + pldat->use_iram = true;
> + else
> + pldat->use_iram = false;
> +
One more thing I just noticed:
this is equivalent to the much shorter
pldat->use_iram = of_property_read_bool(pdev->dev.of_node, "use-iram");
Everything else looks good here.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Roland Stigge <stigge@antcom.de>
Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
w.sang@pengutronix.de, srinivas.bakki@nxp.com,
kevin.wells@nxp.com, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, rtc-linux@googlegroups.com,
a.zummo@towertech.it, linux-watchdog@vger.kernel.org,
wim@iguana.be, jonsmirl@gmail.com
Subject: Re: [PATCH v2 3/8] net: Add device tree support to LPC32xx
Date: Mon, 2 Apr 2012 19:37:54 +0000 [thread overview]
Message-ID: <201204021937.54567.arnd@arndb.de> (raw)
In-Reply-To: <1333391587-26290-4-git-send-email-stigge@antcom.de>
On Monday 02 April 2012, Roland Stigge wrote:
>
> + if (pdev->dev.of_node && of_get_property(pdev->dev.of_node,
> + "use-iram", NULL))
> + pldat->use_iram = true;
> + else
> + pldat->use_iram = false;
> +
One more thing I just noticed:
this is equivalent to the much shorter
pldat->use_iram = of_property_read_bool(pdev->dev.of_node, "use-iram");
Everything else looks good here.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] net: Add device tree support to LPC32xx
Date: Mon, 2 Apr 2012 19:37:54 +0000 [thread overview]
Message-ID: <201204021937.54567.arnd@arndb.de> (raw)
In-Reply-To: <1333391587-26290-4-git-send-email-stigge@antcom.de>
On Monday 02 April 2012, Roland Stigge wrote:
>
> + if (pdev->dev.of_node && of_get_property(pdev->dev.of_node,
> + "use-iram", NULL))
> + pldat->use_iram = true;
> + else
> + pldat->use_iram = false;
> +
One more thing I just noticed:
this is equivalent to the much shorter
pldat->use_iram = of_property_read_bool(pdev->dev.of_node, "use-iram");
Everything else looks good here.
Arnd
next prev parent reply other threads:[~2012-04-02 19:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 18:32 [PATCH v2 0/8]: arm: lpc32xx: Device tree support Roland Stigge
2012-04-02 18:32 ` Roland Stigge
2012-04-02 18:33 ` [PATCH v2 1/8] iio: Add device tree support to LPC32xx ADC Roland Stigge
2012-04-02 18:33 ` Roland Stigge
2012-04-02 18:33 ` [PATCH v2 2/8] rtc: Add device tree support for LPC32xx Roland Stigge
2012-04-02 18:33 ` Roland Stigge
2012-04-02 18:33 ` [PATCH v2 3/8] net: Add device tree support to LPC32xx Roland Stigge
2012-04-02 18:33 ` Roland Stigge
2012-04-02 19:37 ` Arnd Bergmann [this message]
2012-04-02 19:37 ` Arnd Bergmann
2012-04-02 19:37 ` Arnd Bergmann
2012-04-02 18:33 ` [PATCH v2 4/8] wdt: Device tree support for pnx4008-wdt Roland Stigge
2012-04-02 18:33 ` Roland Stigge
2012-04-02 18:33 ` [PATCH v2 5/8] i2c-pnx.c: Fix suspend Roland Stigge
2012-04-02 18:33 ` Roland Stigge
2012-04-02 18:33 ` [PATCH v2 6/8] i2c-pnx.c: Use resources in platforms Roland Stigge
2012-04-02 18:33 ` Roland Stigge
2012-04-02 18:33 ` [PATCH v2 7/8] i2c-pnx.c: Remove duplicated i2c.h Roland Stigge
2012-04-02 18:33 ` Roland Stigge
2012-04-02 18:33 ` [PATCH v2 8/8] i2c: Add device tree support to i2c-pnx.c Roland Stigge
2012-04-02 18:33 ` Roland Stigge
[not found] ` <1333391587-26290-1-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-04-02 19:39 ` [PATCH v2 0/8]: arm: lpc32xx: Device tree support Arnd Bergmann
2012-04-02 19:39 ` Arnd Bergmann
2012-04-02 19:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204021937.54567.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=a.zummo@towertech.it \
--cc=arm@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonsmirl@gmail.com \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
--cc=w.sang@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.