From: Olaf Hering <olaf@aepfle.de>
To: qemu-devel@nongnu.org, xen-devel@lists.xensource.com
Subject: [Qemu-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386
Date: Tue, 3 Apr 2012 19:32:25 +0200 [thread overview]
Message-ID: <20120403173224.GA22140@aepfle.de> (raw)
configure will generate incorrect CFLAGS which will lead to compile
errors due to unknown gcc options, iff CFLAGS was already in the
environment during configure invocation.
Add a space before the -march=i486 gcc option.
Remove += operator usage because configure is not a bash script.
This patch is against the qemu-xen tree, but it should apply also to
qemu.git since it has the same issue. Please apply to both trees.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: qemu-xen-dir-remote/configure
===================================================================
--- qemu-xen-dir-remote.orig/configure
+++ qemu-xen-dir-remote/configure
@@ -2637,7 +2637,7 @@ int main(int argc, char **argv)
}
EOF
if ! compile_prog "" "" ; then
- CFLAGS+="-march=i486"
+ CFLAGS="$CFLAGS -march=i486"
fi
fi
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olaf@aepfle.de>
To: qemu-devel@nongnu.org, xen-devel@lists.xensource.com
Subject: [PATCH v2] qemu/configure: fix CFLAGS handling for i386
Date: Tue, 3 Apr 2012 19:32:25 +0200 [thread overview]
Message-ID: <20120403173224.GA22140@aepfle.de> (raw)
configure will generate incorrect CFLAGS which will lead to compile
errors due to unknown gcc options, iff CFLAGS was already in the
environment during configure invocation.
Add a space before the -march=i486 gcc option.
Remove += operator usage because configure is not a bash script.
This patch is against the qemu-xen tree, but it should apply also to
qemu.git since it has the same issue. Please apply to both trees.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: qemu-xen-dir-remote/configure
===================================================================
--- qemu-xen-dir-remote.orig/configure
+++ qemu-xen-dir-remote/configure
@@ -2637,7 +2637,7 @@ int main(int argc, char **argv)
}
EOF
if ! compile_prog "" "" ; then
- CFLAGS+="-march=i486"
+ CFLAGS="$CFLAGS -march=i486"
fi
fi
next reply other threads:[~2012-04-03 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 17:32 Olaf Hering [this message]
2012-04-03 17:32 ` [PATCH v2] qemu/configure: fix CFLAGS handling for i386 Olaf Hering
2012-04-04 15:16 ` [Qemu-devel] [Xen-devel] " Ian Jackson
2012-04-04 15:16 ` Ian Jackson
2012-04-04 15:40 ` [Qemu-devel] [Xen-devel] " Peter Maydell
2012-04-04 15:40 ` [Qemu-devel] " Peter Maydell
2012-04-04 16:09 ` [Qemu-devel] [Xen-devel] " Peter Maydell
2012-04-04 16:09 ` [Qemu-devel] " Peter Maydell
2012-04-05 7:28 ` [Qemu-devel] [Xen-devel] " Andreas Färber
2012-04-05 7:28 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403173224.GA22140@aepfle.de \
--to=olaf@aepfle.de \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.