From: Tony Lindgren <tony@atomide.com>
To: "Govindraj.R" <govindraj.raja@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Felipe Balbi <balbi@ti.com>, Kevin Hilman <khilman@ti.com>
Subject: Re: [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads
Date: Tue, 3 Apr 2012 11:19:26 -0700 [thread overview]
Message-ID: <20120403181925.GH8240@atomide.com> (raw)
In-Reply-To: <1332324149-16058-1-git-send-email-govindraj.raja@ti.com>
* Govindraj.R <govindraj.raja@ti.com> [120321 03:06]:
> From: "Govindraj.R" <govindraj.raja@ti.com>
>
> The following commit:
> (7496ba3 ARM: OMAP2+: UART: Add default mux for all uarts)
> added default pads for all uarts. But not all boards tend to
> use all uarts and most of unused uart pins are muxed for
> other purpose. This commit breaks the modules which where trying
> to use unused uart pins on their boards.
>
> So remove all default pads except uart1/3 as most boards
> tend to use either uart1/3 as console port and use only tx/rx
> lines, declare only those pads for uart1/3.
> If any boards tend to use any other uart other uart1/3
> the mux data should to passed from board file and init individual
> uart port using omap_serial_init_port api.
This is still wrong. We can't mux any serial pins unless specifically
requested from the board-*.c files. So please do a fix to get back to
v3.2 behaviour where you basically revert 7496ba3.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads
Date: Tue, 3 Apr 2012 11:19:26 -0700 [thread overview]
Message-ID: <20120403181925.GH8240@atomide.com> (raw)
In-Reply-To: <1332324149-16058-1-git-send-email-govindraj.raja@ti.com>
* Govindraj.R <govindraj.raja@ti.com> [120321 03:06]:
> From: "Govindraj.R" <govindraj.raja@ti.com>
>
> The following commit:
> (7496ba3 ARM: OMAP2+: UART: Add default mux for all uarts)
> added default pads for all uarts. But not all boards tend to
> use all uarts and most of unused uart pins are muxed for
> other purpose. This commit breaks the modules which where trying
> to use unused uart pins on their boards.
>
> So remove all default pads except uart1/3 as most boards
> tend to use either uart1/3 as console port and use only tx/rx
> lines, declare only those pads for uart1/3.
> If any boards tend to use any other uart other uart1/3
> the mux data should to passed from board file and init individual
> uart port using omap_serial_init_port api.
This is still wrong. We can't mux any serial pins unless specifically
requested from the board-*.c files. So please do a fix to get back to
v3.2 behaviour where you basically revert 7496ba3.
Tony
next prev parent reply other threads:[~2012-04-03 18:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 10:02 [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads Govindraj.R
2012-03-21 10:02 ` Govindraj.R
2012-04-03 18:19 ` Tony Lindgren [this message]
2012-04-03 18:19 ` Tony Lindgren
2012-04-04 6:14 ` Raja, Govindraj
2012-04-04 6:14 ` Raja, Govindraj
2012-04-05 16:58 ` Tony Lindgren
2012-04-05 16:58 ` Tony Lindgren
2012-04-05 17:02 ` Tony Lindgren
2012-04-05 17:02 ` Tony Lindgren
2012-04-06 6:05 ` Raja, Govindraj
2012-04-06 6:05 ` Raja, Govindraj
2012-04-06 18:15 ` Tony Lindgren
2012-04-06 18:15 ` Tony Lindgren
2012-04-09 11:08 ` Raja, Govindraj
2012-04-09 11:08 ` Raja, Govindraj
2012-04-09 16:56 ` Russ Dill
2012-04-09 16:56 ` Russ Dill
2012-04-09 20:36 ` Tony Lindgren
2012-04-09 20:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403181925.GH8240@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=govindraj.raja@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.