All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support
@ 2012-04-02  1:40 Kuninori Morimoto
  2012-04-02  5:06 ` Simon Horman
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2012-04-02  1:40 UTC (permalink / raw)
  To: linux-sh

We needs un-manualed address to use DMA

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/mach-shmobile/board-mackerel.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index 13ba0ac..ff73e5a 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -922,6 +922,8 @@ fsi_set_rate_end:
 static struct sh_fsi_platform_info fsi_info = {
 	.port_a = {
 		.flags = SH_FSI_BRS_INV,
+		.tx_id = SHDMA_SLAVE_FSIA_TX,
+		.rx_id = SHDMA_SLAVE_FSIA_RX,
 	},
 	.port_b = {
 		.flags = SH_FSI_BRS_INV	|
@@ -934,9 +936,11 @@ static struct sh_fsi_platform_info fsi_info = {
 
 static struct resource fsi_resources[] = {
 	[0] = {
+		/* we need 0xFE1F0000 to access DMA
+		 * instead of 0xFE3C0000 */
 		.name	= "FSI",
-		.start	= 0xFE3C0000,
-		.end	= 0xFE3C0400 - 1,
+		.start  = 0xFE1F0000,
+		.end    = 0xFE1F0400 - 1,
 		.flags	= IORESOURCE_MEM,
 	},
 	[1] = {
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support
  2012-04-02  1:40 [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support Kuninori Morimoto
@ 2012-04-02  5:06 ` Simon Horman
  2012-04-02  5:31 ` Kuninori Morimoto
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2012-04-02  5:06 UTC (permalink / raw)
  To: linux-sh

On Sun, Apr 01, 2012 at 06:40:14PM -0700, Kuninori Morimoto wrote:
> We needs un-manualed address to use DMA

Hi Morimoto-san,

can I clarify that you mean Undocumented?


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support
  2012-04-02  1:40 [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support Kuninori Morimoto
  2012-04-02  5:06 ` Simon Horman
@ 2012-04-02  5:31 ` Kuninori Morimoto
  2012-04-04  5:39 ` Simon Horman
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2012-04-02  5:31 UTC (permalink / raw)
  To: linux-sh


Hi Simon

> > We needs un-manualed address to use DMA
> 
> Hi Morimoto-san,
> 
> can I clarify that you mean Undocumented?

Oops. sorry for my English.
Yes. Undocumented

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support
  2012-04-02  1:40 [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support Kuninori Morimoto
  2012-04-02  5:06 ` Simon Horman
  2012-04-02  5:31 ` Kuninori Morimoto
@ 2012-04-04  5:39 ` Simon Horman
  2012-04-04  5:49 ` Kuninori Morimoto
  2012-04-04  6:06 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2012-04-04  5:39 UTC (permalink / raw)
  To: linux-sh

Hi Morimoto-san,

On Sun, Apr 01, 2012 at 06:40:14PM -0700, Kuninori Morimoto wrote:
> We needs un-manualed address to use DMA
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  arch/arm/mach-shmobile/board-mackerel.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 13ba0ac..ff73e5a 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -922,6 +922,8 @@ fsi_set_rate_end:
>  static struct sh_fsi_platform_info fsi_info = {
>  	.port_a = {
>  		.flags = SH_FSI_BRS_INV,
> +		.tx_id = SHDMA_SLAVE_FSIA_TX,
> +		.rx_id = SHDMA_SLAVE_FSIA_RX,
>  	},
>  	.port_b = {
>  		.flags = SH_FSI_BRS_INV	|

Which tree does this apply to or is there a dependency?
I'm having trouble with the above hunk both on v3.3 and
the soc branch of Rafael's renesas tree.

> @@ -934,9 +936,11 @@ static struct sh_fsi_platform_info fsi_info = {
>  
>  static struct resource fsi_resources[] = {
>  	[0] = {
> +		/* we need 0xFE1F0000 to access DMA
> +		 * instead of 0xFE3C0000 */
>  		.name	= "FSI",
> -		.start	= 0xFE3C0000,
> -		.end	= 0xFE3C0400 - 1,
> +		.start  = 0xFE1F0000,
> +		.end    = 0xFE1F0400 - 1,
>  		.flags	= IORESOURCE_MEM,
>  	},
>  	[1] = {
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support
  2012-04-02  1:40 [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support Kuninori Morimoto
                   ` (2 preceding siblings ...)
  2012-04-04  5:39 ` Simon Horman
@ 2012-04-04  5:49 ` Kuninori Morimoto
  2012-04-04  6:06 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2012-04-04  5:49 UTC (permalink / raw)
  To: linux-sh


Hi Simon

> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> >  arch/arm/mach-shmobile/board-mackerel.c |    8 ++++++--
> >  1 files changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> > index 13ba0ac..ff73e5a 100644
> > --- a/arch/arm/mach-shmobile/board-mackerel.c
> > +++ b/arch/arm/mach-shmobile/board-mackerel.c
> > @@ -922,6 +922,8 @@ fsi_set_rate_end:
> >  static struct sh_fsi_platform_info fsi_info = {
> >  	.port_a = {
> >  		.flags = SH_FSI_BRS_INV,
> > +		.tx_id = SHDMA_SLAVE_FSIA_TX,
> > +		.rx_id = SHDMA_SLAVE_FSIA_RX,
> >  	},
> >  	.port_b = {
> >  		.flags = SH_FSI_BRS_INV	|
> 
> Which tree does this apply to or is there a dependency?
> I'm having trouble with the above hunk both on v3.3 and
> the soc branch of Rafael's renesas tree.

It is for latest linus/master tree.
Does your branch has this commit ?

-------------------
commit 7da9ced6066c654a22836c24bae509ef323e10a8
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date:   Fri Feb 3 00:59:33 2012 -0800

    ASoC: fsi: Add DMAEngine support
    
    This patch supports DMAEngine to FSI driver.
    It supports only Tx case at this point.
    If platform/cpu doesn't support DMAEngine, FSI driver will
    use PIO transfer.
    
-------------------

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support
  2012-04-02  1:40 [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support Kuninori Morimoto
                   ` (3 preceding siblings ...)
  2012-04-04  5:49 ` Kuninori Morimoto
@ 2012-04-04  6:06 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2012-04-04  6:06 UTC (permalink / raw)
  To: linux-sh

On Tue, Apr 03, 2012 at 10:49:12PM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > >  arch/arm/mach-shmobile/board-mackerel.c |    8 ++++++--
> > >  1 files changed, 6 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> > > index 13ba0ac..ff73e5a 100644
> > > --- a/arch/arm/mach-shmobile/board-mackerel.c
> > > +++ b/arch/arm/mach-shmobile/board-mackerel.c
> > > @@ -922,6 +922,8 @@ fsi_set_rate_end:
> > >  static struct sh_fsi_platform_info fsi_info = {
> > >  	.port_a = {
> > >  		.flags = SH_FSI_BRS_INV,
> > > +		.tx_id = SHDMA_SLAVE_FSIA_TX,
> > > +		.rx_id = SHDMA_SLAVE_FSIA_RX,
> > >  	},
> > >  	.port_b = {
> > >  		.flags = SH_FSI_BRS_INV	|
> > 
> > Which tree does this apply to or is there a dependency?
> > I'm having trouble with the above hunk both on v3.3 and
> > the soc branch of Rafael's renesas tree.
> 
> It is for latest linus/master tree.

Thanks, I now have the patches applied against linus/master.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-04-04  6:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-02  1:40 [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support Kuninori Morimoto
2012-04-02  5:06 ` Simon Horman
2012-04-02  5:31 ` Kuninori Morimoto
2012-04-04  5:39 ` Simon Horman
2012-04-04  5:49 ` Kuninori Morimoto
2012-04-04  6:06 ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.