From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Rafal Prylowski <prylowski@metasoft.pl>,
"rmallon@gmail.com" <rmallon@gmail.com>,
Sergei Shtylyov <sshtylyov@mvista.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"joao.ramos@inov.pt" <joao.ramos@inov.pt>,
H Hartley Sweeten <hartleys@visionengravers.com>,
"bzolnier@gmail.com" <bzolnier@gmail.com>
Subject: Re: [PATCH v2 1/3] PATA host controller driver for ep93xx
Date: Wed, 4 Apr 2012 15:23:50 +0000 [thread overview]
Message-ID: <201204041523.50872.arnd@arndb.de> (raw)
In-Reply-To: <4F7C65CE.6000309@metasoft.pl>
On Wednesday 04 April 2012, Rafal Prylowski wrote:
> >
> > According to ATA specification, maximum IORDY pulse width is 1250ns,
> > so I'll set timeout to 2ms (I should check this before posting the driver..).
>
> 2ms is far too big value... Should be 2us.
Ok, in this case, don't use jiffies. I guess it was already flawed because
jiffies doesn't get updated while you are in an interrupt handler.
You could use ktime_get to get a high-resolution time stamp to compare to,
but it depends on how accurate your clocksource is.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] PATA host controller driver for ep93xx
Date: Wed, 4 Apr 2012 15:23:50 +0000 [thread overview]
Message-ID: <201204041523.50872.arnd@arndb.de> (raw)
In-Reply-To: <4F7C65CE.6000309@metasoft.pl>
On Wednesday 04 April 2012, Rafal Prylowski wrote:
> >
> > According to ATA specification, maximum IORDY pulse width is 1250ns,
> > so I'll set timeout to 2ms (I should check this before posting the driver..).
>
> 2ms is far too big value... Should be 2us.
Ok, in this case, don't use jiffies. I guess it was already flawed because
jiffies doesn't get updated while you are in an interrupt handler.
You could use ktime_get to get a high-resolution time stamp to compare to,
but it depends on how accurate your clocksource is.
Arnd
next prev parent reply other threads:[~2012-04-04 15:24 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 14:42 [PATCH v2 0/3] Add PATA host controller support for Cirrus Logic EP93xx CPU Rafal Prylowski
2012-04-03 14:42 ` Rafal Prylowski
2012-04-03 14:45 ` [PATCH v2 1/3] PATA host controller driver for ep93xx Rafal Prylowski
2012-04-03 14:45 ` Rafal Prylowski
2012-04-03 18:25 ` H Hartley Sweeten
2012-04-03 18:25 ` H Hartley Sweeten
2012-04-03 20:08 ` Arnd Bergmann
2012-04-03 20:08 ` Arnd Bergmann
2012-04-03 20:37 ` H Hartley Sweeten
2012-04-03 20:37 ` H Hartley Sweeten
2012-04-04 12:50 ` Arnd Bergmann
2012-04-04 12:50 ` Arnd Bergmann
2012-04-04 12:40 ` Rafal Prylowski
2012-04-04 12:40 ` Rafal Prylowski
2012-04-04 13:23 ` Arnd Bergmann
2012-04-04 13:23 ` Arnd Bergmann
2012-04-04 15:11 ` Rafal Prylowski
2012-04-04 15:11 ` Rafal Prylowski
2012-04-04 15:16 ` Rafal Prylowski
2012-04-04 15:16 ` Rafal Prylowski
2012-04-04 15:23 ` Arnd Bergmann [this message]
2012-04-04 15:23 ` Arnd Bergmann
2012-04-05 7:52 ` Rafal Prylowski
2012-04-05 7:52 ` Rafal Prylowski
2012-04-05 9:07 ` Rafal Prylowski
2012-04-05 9:07 ` Rafal Prylowski
2012-04-04 7:39 ` Rafal Prylowski
2012-04-04 7:39 ` Rafal Prylowski
2012-04-03 18:55 ` H Hartley Sweeten
2012-04-03 18:55 ` H Hartley Sweeten
2012-04-04 7:47 ` Rafal Prylowski
2012-04-04 7:47 ` Rafal Prylowski
2012-04-03 14:47 ` [PATCH v2 2/3] ep93xx: IDE driver platform support code Rafal Prylowski
2012-04-03 14:47 ` Rafal Prylowski
2012-04-03 17:41 ` H Hartley Sweeten
2012-04-03 17:41 ` H Hartley Sweeten
2012-04-04 8:41 ` Rafal Prylowski
2012-04-04 8:41 ` Rafal Prylowski
2012-04-04 16:20 ` H Hartley Sweeten
2012-04-04 16:20 ` H Hartley Sweeten
2012-04-04 16:43 ` H Hartley Sweeten
2012-04-04 16:43 ` H Hartley Sweeten
2012-04-04 17:11 ` H Hartley Sweeten
2012-04-04 17:11 ` H Hartley Sweeten
2012-04-05 12:15 ` Rafal Prylowski
2012-04-04 1:43 ` H Hartley Sweeten
2012-04-04 1:43 ` H Hartley Sweeten
2012-04-03 14:48 ` [PATCH v2 3/3] ep93xx: Add IDE support to edb93xx boards Rafal Prylowski
2012-04-03 14:48 ` Rafal Prylowski
2012-04-03 17:44 ` H Hartley Sweeten
2012-04-03 17:44 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204041523.50872.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=bzolnier@gmail.com \
--cc=hartleys@visionengravers.com \
--cc=joao.ramos@inov.pt \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=prylowski@metasoft.pl \
--cc=rmallon@gmail.com \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.