From: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 04/11] gpio: tegra: Iterate over the correct number of banks
Date: Wed, 4 Apr 2012 10:58:29 -0700 [thread overview]
Message-ID: <20120404175829.GD29919@quad.lixom.net> (raw)
In-Reply-To: <1333148404-17691-5-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Fri, Mar 30, 2012 at 04:59:57PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> When Tegra30 support was added to the Tegra GPIO driver, a few places
> which iterated over all banks were not converted to use the variable
> tegra_gpio_bank_count rather than hard-coding the bank count. Fix this.
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Should this be fixed in 3.4 as well? Given the need for some of the other
patches in this series I suppose gpio isn't really working on tegra30 there
though, so it's not technically a regression...
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/11] gpio: tegra: Iterate over the correct number of banks
Date: Wed, 4 Apr 2012 10:58:29 -0700 [thread overview]
Message-ID: <20120404175829.GD29919@quad.lixom.net> (raw)
In-Reply-To: <1333148404-17691-5-git-send-email-swarren@wwwdotorg.org>
On Fri, Mar 30, 2012 at 04:59:57PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> When Tegra30 support was added to the Tegra GPIO driver, a few places
> which iterated over all banks were not converted to use the variable
> tegra_gpio_bank_count rather than hard-coding the bank count. Fix this.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Olof Johansson <olof@lixom.net>
Should this be fixed in 3.4 as well? Given the need for some of the other
patches in this series I suppose gpio isn't really working on tegra30 there
though, so it's not technically a regression...
-Olof
next prev parent reply other threads:[~2012-04-04 17:58 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 22:59 [PATCH 00/11] ARM: tegra: GPIO and pinmux-related changes Stephen Warren
2012-03-30 22:59 ` Stephen Warren
[not found] ` <1333148404-17691-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-30 22:59 ` [PATCH 01/11] usb: ehci-tegra: Add vbus_gpio to platform data Stephen Warren
2012-03-30 22:59 ` Stephen Warren
[not found] ` <1333148404-17691-2-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-04 17:51 ` Olof Johansson
2012-04-04 17:51 ` Olof Johansson
2012-03-30 22:59 ` [PATCH 02/11] ARM: tegra: Remove VBUS_GPIO handling from board files Stephen Warren
2012-03-30 22:59 ` Stephen Warren
[not found] ` <1333148404-17691-3-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-04 17:52 ` Olof Johansson
2012-04-04 17:52 ` Olof Johansson
2012-03-30 22:59 ` [PATCH 03/11] gpio: tegra: fix register address calculations for Tegra30 Stephen Warren
2012-03-30 22:59 ` Stephen Warren
[not found] ` <1333148404-17691-4-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-04 17:57 ` Olof Johansson
2012-04-04 17:57 ` Olof Johansson
[not found] ` <20120404175722.GC29919-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2012-04-04 18:53 ` Stephen Warren
2012-04-04 18:53 ` Stephen Warren
[not found] ` <4F7C9893.1030704-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-04 18:57 ` Olof Johansson
2012-04-04 18:57 ` Olof Johansson
2012-03-30 22:59 ` [PATCH 04/11] gpio: tegra: Iterate over the correct number of banks Stephen Warren
2012-03-30 22:59 ` Stephen Warren
[not found] ` <1333148404-17691-5-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-04 17:58 ` Olof Johansson [this message]
2012-04-04 17:58 ` Olof Johansson
[not found] ` <20120404175829.GD29919-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2012-04-04 18:41 ` Stephen Warren
2012-04-04 18:41 ` Stephen Warren
[not found] ` <4F7C95F2.2050808-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-04 18:59 ` Olof Johansson
2012-04-04 18:59 ` Olof Johansson
2012-03-30 22:59 ` [PATCH 05/11] gpio: tegra: configure pins during irq_set_type Stephen Warren
2012-03-30 22:59 ` Stephen Warren
[not found] ` <1333148404-17691-6-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-04 17:58 ` Olof Johansson
2012-04-04 17:58 ` Olof Johansson
2012-03-30 22:59 ` [PATCH 06/11] ARM: tegra: seaboard: Don't gpio_request() ISL29018_IRQ Stephen Warren
2012-03-30 22:59 ` Stephen Warren
[not found] ` <1333148404-17691-7-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-04 17:59 ` Olof Johansson
2012-04-04 17:59 ` Olof Johansson
2012-03-30 23:00 ` [PATCH 08/11] ARM: tegra: Switch to new pinctrl driver Stephen Warren
2012-03-30 23:00 ` Stephen Warren
[not found] ` <1333148404-17691-9-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-03 20:49 ` Linus Walleij
2012-04-03 20:49 ` Linus Walleij
2012-04-04 18:49 ` Olof Johansson
2012-04-04 18:49 ` Olof Johansson
2012-03-30 23:00 ` [PATCH 09/11] ARM: tegra: Remove pre-pinctrl pinmux driver Stephen Warren
2012-03-30 23:00 ` Stephen Warren
2012-03-30 23:00 ` [PATCH 10/11] ARM: dt: tegra cardhu: add pinmux to device tree Stephen Warren
2012-03-30 23:00 ` Stephen Warren
[not found] ` <1333148404-17691-11-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-04 18:52 ` Olof Johansson
2012-04-04 18:52 ` Olof Johansson
2012-03-30 23:00 ` [PATCH 11/11] ARM: dt: tegra20: " Stephen Warren
2012-03-30 23:00 ` Stephen Warren
[not found] ` <1333148404-17691-12-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-03 20:51 ` Linus Walleij
2012-04-03 20:51 ` Linus Walleij
2012-04-04 19:14 ` Olof Johansson
2012-04-04 19:14 ` Olof Johansson
2012-04-04 19:16 ` [PATCH 00/11] ARM: tegra: GPIO and pinmux-related changes Olof Johansson
2012-04-04 19:16 ` Olof Johansson
2012-03-30 23:00 ` [PATCH 07/11] gpio: tegra: Hide tegra_gpio_enable/disable() Stephen Warren
2012-03-30 23:00 ` Stephen Warren
[not found] ` <1333148404-17691-8-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-01 4:32 ` Chris Ball
2012-04-01 4:32 ` Chris Ball
2012-04-01 9:54 ` Linus Walleij
2012-04-01 9:54 ` Linus Walleij
2012-04-04 18:01 ` Olof Johansson
2012-04-04 18:01 ` Olof Johansson
2012-04-09 1:09 ` Chris Ball
2012-04-09 1:09 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404175829.GD29919@quad.lixom.net \
--to=olof-nzht3qvonbneowh0uzbu5w@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.