[PATCH] Bluetooth: Send Connect failed event when LE Connection fails

[PATCH] Bluetooth: Send Connect failed event when LE Connection fails

[Hemant Gupta]

This patch adds management connect failed event when LE Create Connection
Command fails to inform BlueZ that LE Connection failed to get established.

Signed-off-by: Hemant Gupta <hemant.gupta@stericsson.com>
---
 net/bluetooth/hci_event.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 7325300..89662f0 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1649,6 +1649,8 @@ static void hci_cs_le_create_conn(struct hci_dev *hdev, __u8 status)
 	if (status) {
 		if (conn && conn->state == BT_CONNECT) {
 			conn->state = BT_CLOSED;
+			mgmt_connect_failed(hdev, &cp->peer_addr, conn->type,
+							conn->dst_type, status);
 			hci_proto_connect_cfm(conn, status);
 			hci_conn_del(conn);
 		}
-- 
1.7.0.4

Re: [PATCH] Bluetooth: Send Connect failed event when LE Connection fails

[Johan Hedberg]

Hi Hemant,

On Thu, Apr 05, 2012, Hemant Gupta wrote:
> This patch adds management connect failed event when LE Create Connection
> Command fails to inform BlueZ that LE Connection failed to get established.

s/BlueZ/user space/

Also change the summary line to:

Bluetooth: mgmt: Fix missing connect failed event for LE

> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -1649,6 +1649,8 @@ static void hci_cs_le_create_conn(struct hci_dev *hdev, __u8 status)
>  	if (status) {
>  		if (conn && conn->state == BT_CONNECT) {
>  			conn->state = BT_CLOSED;
> +			mgmt_connect_failed(hdev, &cp->peer_addr, conn->type,
> +							conn->dst_type, status);
>  			hci_proto_connect_cfm(conn, status);
>  			hci_conn_del(conn);
>  		}

Please use our new alignment style for split lines, i.e. align with the
opening parenthesis.

Johan

Re: [PATCH] Bluetooth: Send Connect failed event when LE Connection fails

[Hemant Gupta]

Hi Johan,

On Thu, Apr 5, 2012 at 4:34 PM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> Hi Hemant,
>
> On Thu, Apr 05, 2012, Hemant Gupta wrote:
>> This patch adds management connect failed event when LE Create Connection
>> Command fails to inform BlueZ that LE Connection failed to get established.
>
> s/BlueZ/user space/
>
> Also change the summary line to:
>
> Bluetooth: mgmt: Fix missing connect failed event for LE
>
Thanks, please have a look at my new patch.
>> --- a/net/bluetooth/hci_event.c
>> +++ b/net/bluetooth/hci_event.c
>> @@ -1649,6 +1649,8 @@ static void hci_cs_le_create_conn(struct hci_dev *hdev, __u8 status)
>>       if (status) {
>>               if (conn && conn->state == BT_CONNECT) {
>>                       conn->state = BT_CLOSED;
>> +                     mgmt_connect_failed(hdev, &cp->peer_addr, conn->type,
>> +                                                     conn->dst_type, status);
>>                       hci_proto_connect_cfm(conn, status);
>>                       hci_conn_del(conn);
>>               }
>
> Please use our new alignment style for split lines, i.e. align with the
> opening parenthesis.
>
Done, sent a new patch for review.
> Johan



-- 
Best Regards
Hemant Gupta
ST-Ericsson India