From: Andrew Morton <akpm@linux-foundation.org>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, <rpurdie@rpsys.net>,
<linux-kernel@vger.kernel.org>,
David Dajun Chen <Dajun.Chen@diasemi.com>
Subject: Re: [PATCH] LEDS: LED module for DA9052/53 PMIC v2
Date: Thu, 5 Apr 2012 15:52:58 -0700 [thread overview]
Message-ID: <20120405155258.6af697f3.akpm@linux-foundation.org> (raw)
In-Reply-To: <1329916149.24042.7.camel@dhruva>
On Wed, 22 Feb 2012 18:39:09 +0530
Ashish Jangam <ashish.jangam@kpitcummins.com> wrote:
> LED Driver for Dialog Semiconductor DA9052/53 PMICs.
>
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
This email was cc'ed to Dajun.Chen@diasemi.com. I'll assume that both
work correctly.
> drivers/leds/Kconfig | 8 ++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-da9052.c | 214 ++++++++++++++++++++++++++++++++++++++++++++
Looks OK. I added one little fixup:
--- a/drivers/leds/leds-da9052.c~leds-led-module-for-da9052-53-pmic-v2-fix
+++ a/drivers/leds/leds-da9052.c
@@ -40,7 +40,7 @@ struct da9052_led {
int brightness;
};
-unsigned char led_reg[] = {
+static unsigned char led_reg[] = {
DA9052_LED_CONT_4_REG,
DA9052_LED_CONT_5_REG,
};
This array could actually be made static within da9052_set_led_brightness().
prev parent reply other threads:[~2012-04-05 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 13:09 [PATCH] LEDS: LED module for DA9052/53 PMIC v2 Ashish Jangam
2012-03-13 12:26 ` Ashish Jangam
2012-03-15 16:50 ` Lars-Peter Clausen
2012-04-05 22:46 ` Andrew Morton
2012-04-05 22:52 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405155258.6af697f3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Dajun.Chen@diasemi.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.