From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Axel Lin <axel.lin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: rc5t583: Simplify RC5T583_REG macro
Date: Fri, 6 Apr 2012 09:51:15 +0100 [thread overview]
Message-ID: <20120406085115.GD3172@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F7E8030.80000@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Fri, Apr 06, 2012 at 11:03:36AM +0530, Laxman Dewangan wrote:
> I thought of doing this on my first patch and then thought that
> table should have all configuration picture rather than deriving
> from few parameters.
> If this is a good way then I will take care for my next PMIC driver
> development.
This way is good - if you look at for example the wm831x driver where
there's a bunch of regulators with the same register layout replicated
in different places in the chip all it does is specify the base for the
block when defining a regulator.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-06 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 0:01 [PATCH] regulator: rc5t583: Simplify RC5T583_REG macro Axel Lin
2012-04-06 5:33 ` Laxman Dewangan
2012-04-06 8:51 ` Mark Brown [this message]
2012-04-06 8:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120406085115.GD3172@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.