All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] regulator: rc5t583: Simplify RC5T583_REG macro
Date: Fri, 6 Apr 2012 11:03:36 +0530	[thread overview]
Message-ID: <4F7E8030.80000@nvidia.com> (raw)
In-Reply-To: <1333670496.2777.0.camel@phoenix>

On Friday 06 April 2012 05:31 AM, Axel Lin wrote:
> Simplify RC5T583_REG macro by removing _vout_reg and _ds_reg parameters.
>
> The naming for vout_reg and deepsleep_reg can be replaced by:
> .vout_reg       = RC5T583_REG_##_id##DAC,
> .deepsleep_reg  = RC5T583_REG_##_id##DAC_DS,
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---

Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

I thought of doing this on my first patch and then thought that table 
should have all configuration picture rather than deriving  from few 
parameters.
If this is a good way then I will take care for my next PMIC driver 
development.

Thanks,
Laxman

  reply	other threads:[~2012-04-06  5:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-06  0:01 [PATCH] regulator: rc5t583: Simplify RC5T583_REG macro Axel Lin
2012-04-06  5:33 ` Laxman Dewangan [this message]
2012-04-06  8:51   ` Mark Brown
2012-04-06  8:49 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7E8030.80000@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.